Change loop bounds to be correct (and much less confusing)

gm/recordopts.cpp

 /*
  * Copyright 2014 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "gm.h"
 #include "SkCanvas.h"
 #include "SkPath.h"
@@ skipping 172 matching lines @@
         SkColorSetARGB(255, 0, (kDetectorGreenValue + 1), 0) // This tests that detectors work.
     };
 
     InstallDetectorFunc detectorInstallFuncs[] = {
         install_detector_image_filter,
         install_detector_color_filter
     };
 
     for (size_t i = 0; i < SK_ARRAY_COUNT(shapeColors); ++i) {
         shapeColor = shapeColors[i];
-        for (size_t j = 0; j < SK_ARRAY_COUNT(shapeColors); ++j) {
+        for (size_t j = 0; j < SK_ARRAY_COUNT(detectorInstallFuncs); ++j) {

[reed1, 2016/06/23 17:43:29]

can we use the fancy style (and be perhaps even clearer)?

e.g.
for (auto shapeColor : shapeColors) {
   for (auto installFunc : detectorInstallFuncs) {
      ...

             InstallDetectorFunc detectorInstallFunc = detectorInstallFuncs[j];
             for (size_t k = 0; k < SK_ARRAY_COUNT(funcs); ++k) {
                 TestVariantSequence drawTestSequence = funcs[k];
                 canvas->save();
                 drawTestSequence(canvas, shapeColor, detectorInstallFunc);
                 canvas->flush();
                 canvas->translate(SkIntToScalar(kTestRectSize) + SkIntToScalar(1), SkIntToScalar(0));
                 {
                     SkPictureRecorder recorder;
                     drawTestSequence(recorder.beginRecording(SkIntToScalar(kTestRectSize),
                                                              SkIntToScalar(kTestRectSize)),
                                      shapeColor, detectorInstallFunc);
                     recorder.finishRecordingAsPicture()->playback(canvas);
                     canvas->flush();
                 }
 
                 canvas->restore();
                 canvas->translate(SkIntToScalar(0), SkIntToScalar(kTestRectSize) + SkIntToScalar(1));
             }
 
         }
     }
 }