components/variations/variations_seed_store.cc - Issue 2095553002: Make callers of FromUTC(Local)Exploded in components/ use new time API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/variations/variations_seed_store.cc

Issue 2095553002: Make callers of FromUTC(Local)Exploded in components/ use new time API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fukino's comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/variations/variations_seed_store.cc

diff --git a/components/variations/variations_seed_store.cc b/components/variations/variations_seed_store.cc

index 65b1efd1b5c5346876f4ac7d0c30dc447575cd34..8067651b43545cfdde56d9501a89ec2995f35a05 100644

--- a/components/variations/variations_seed_store.cc

+++ b/components/variations/variations_seed_store.cc

@@ -112,7 +112,10 @@ base::Time TruncateToUTCDay(const base::Time& time) {

exploded.second = 0;

exploded.millisecond = 0;

- return base::Time::FromUTCExploded(exploded);

+ base::Time out_time;

+ bool conversion_success = base::Time::FromUTCExploded(exploded, &out_time);

+ DCHECK(conversion_success);

+ return out_time;

}

VariationsSeedDateChangeState GetSeedDateChangeState(

« no previous file with comments | « components/password_manager/core/browser/password_store.cc ('k') | no next file » | no next file with comments »