Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: components/password_manager/core/browser/password_store.cc

Issue 2095553002: Make callers of FromUTC(Local)Exploded in components/ use new time API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fukino's comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_store.cc
diff --git a/components/password_manager/core/browser/password_store.cc b/components/password_manager/core/browser/password_store.cc
index 9842dc2b545492c5b6757e01b8018133f34a776f..1ffb69d04692c1b1c8f90ffea44624e2ddcc92bf 100644
--- a/components/password_manager/core/browser/password_store.cc
+++ b/components/password_manager/core/browser/password_store.cc
@@ -177,7 +177,11 @@ void PasswordStore::GetLogins(const PasswordForm& form,
form.signon_realm == "https://www.google.com/")) {
static const base::Time::Exploded exploded_cutoff =
{ 2012, 1, 0, 1, 0, 0, 0, 0 }; // 00:00 Jan 1 2012
- ignore_logins_cutoff = base::Time::FromUTCExploded(exploded_cutoff);
+ base::Time out_time;
+ bool conversion_success =
+ base::Time::FromUTCExploded(exploded_cutoff, &out_time);
+ DCHECK(conversion_success);
+ ignore_logins_cutoff = out_time;
}
std::unique_ptr<GetLoginsRequest> request(new GetLoginsRequest(consumer));
request->set_ignore_logins_cutoff(ignore_logins_cutoff);
« no previous file with comments | « components/ntp_snippets/ntp_snippets_service_unittest.cc ('k') | components/variations/variations_seed_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698