Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 209543002: Revert of Don't rely on values computed as a side effect of paint. (Closed)

Created:
6 years, 9 months ago by Ian Vollick
Modified:
6 years, 9 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering, pdr., rune+blink
Visibility:
Public.

Description

Revert of Don't rely on values computed as a side effect of paint. (https://codereview.chromium.org/208203002/) Reason for revert: Looks like this is causing ASSERTs due to calling layout-dependent code at the wrong time: https://code.google.com/p/chromium/issues/detail?id=355277 Original issue's description: > Don't rely on values computed as a side effect of paint. > > Contrary to the assertions on the bug, the current code is correct. As > the user changes the selection, there will naturally be a visual > affordance to indicate the selection changes. By the time we scroll, > RL::hasBlockSelectionGapsBounds will be current and correct. > > That said, the hope is that in the future paint will have no side > effects at all, nor do we want layout tests to require repaints during > their execution. So even if this is technically correct it's undesirable > on a number of levels. > > This cl replaces the use of hasBlockSelectionGapsBounds with non-paint > related code (in fact, that function could be removed entirely). > > R=abarth@chromium.org > BUG=353827 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169752 TBR=abarth@chromium.org NOTREECHECKS=true NOTRY=true BUG=353827 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169813

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderLayer.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ian Vollick
Created Revert of Don't rely on values computed as a side effect of paint.
6 years, 9 months ago (2014-03-23 16:57:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/209543002/1
6 years, 9 months ago (2014-03-23 16:57:36 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-23 16:57:53 UTC) #3
Message was sent while issue was closed.
Change committed as 169813

Powered by Google App Engine
This is Rietveld 408576698