Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Issue 2095383002: Log error if decryption fails in LoginDatabase (Closed)

Created:
4 years, 5 months ago by vabr (Chromium)
Modified:
4 years, 5 months ago
Reviewers:
vasilii
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Log error if decryption fails in LoginDatabase BUG=607882 R=vasilii@chromium.org Committed: https://crrev.com/03a31a078bea4b2f229ef1e6c7749239caa1910e Cr-Commit-Position: refs/heads/master@{#402183}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Also logging encryption_result #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M components/password_manager/core/browser/login_database.cc View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
vabr (Chromium)
Hi Vasilii, Is this what you had in mind? Cheers, Vaclav
4 years, 5 months ago (2016-06-27 13:50:03 UTC) #1
vasilii
Exactly. LGTM. https://codereview.chromium.org/2095383002/diff/1/components/password_manager/core/browser/login_database.cc File components/password_manager/core/browser/login_database.cc (right): https://codereview.chromium.org/2095383002/diff/1/components/password_manager/core/browser/login_database.cc#newcode1067 components/password_manager/core/browser/login_database.cc:1067: VLOG(0) << "Password decryption failed"; Print encryption_result?
4 years, 5 months ago (2016-06-27 13:54:19 UTC) #2
vabr (Chromium)
Also logging encryption_result
4 years, 5 months ago (2016-06-27 14:36:31 UTC) #3
vabr (Chromium)
https://codereview.chromium.org/2095383002/diff/1/components/password_manager/core/browser/login_database.cc File components/password_manager/core/browser/login_database.cc (right): https://codereview.chromium.org/2095383002/diff/1/components/password_manager/core/browser/login_database.cc#newcode1067 components/password_manager/core/browser/login_database.cc:1067: VLOG(0) << "Password decryption failed"; On 2016/06/27 13:54:18, vasilii ...
4 years, 5 months ago (2016-06-27 14:36:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2095383002/20001
4 years, 5 months ago (2016-06-27 14:36:57 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-27 15:26:30 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 15:28:24 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/03a31a078bea4b2f229ef1e6c7749239caa1910e
Cr-Commit-Position: refs/heads/master@{#402183}

Powered by Google App Engine
This is Rietveld 408576698