Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Unified Diff: components/password_manager/core/browser/login_database.cc

Issue 2095383002: Log error if decryption fails in LoginDatabase (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Also logging encryption_result Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/login_database.cc
diff --git a/components/password_manager/core/browser/login_database.cc b/components/password_manager/core/browser/login_database.cc
index 0cc76ff353d7e289c6516e5d8be8550bb6b9061a..d4e913cd7685f159ad0be44805ebfe05b9d6e9e5 100644
--- a/components/password_manager/core/browser/login_database.cc
+++ b/components/password_manager/core/browser/login_database.cc
@@ -1063,8 +1063,11 @@ LoginDatabase::EncryptionResult LoginDatabase::InitPasswordFormFromStatement(
base::string16 decrypted_password;
EncryptionResult encryption_result =
DecryptedString(encrypted_password, &decrypted_password);
- if (encryption_result != ENCRYPTION_RESULT_SUCCESS)
+ if (encryption_result != ENCRYPTION_RESULT_SUCCESS) {
+ VLOG(0) << "Password decryption failed, encryption_result is "
+ << encryption_result;
return encryption_result;
+ }
std::string tmp = s.ColumnString(COLUMN_ORIGIN_URL);
form->origin = GURL(tmp);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698