Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 2095043004: Fix material Help page redirect, again (Closed)

Created:
4 years, 6 months ago by michaelpg
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang, Dan Beam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix material Help page redirect, again BUG=621390 R=dbeam@chromium.org TEST=SettingsHelpPageBrowserTest # truly tests chrome://help Committed: https://crrev.com/98ae4c9db98d003b559a52692f6e3b7c374c67e4 Cr-Commit-Position: refs/heads/master@{#402045}

Patch Set 1 #

Patch Set 2 : Remove test #

Patch Set 3 : #YOLO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -2 lines) Patch
M chrome/browser/browser_about_handler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/browser_about_handler_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webui/settings/help_page_browsertest.js View 1 2 1 chunk +44 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
michaelpg
Follow-up to https://codereview.chromium.org/2088473002 (patch set 4 undid my fix for chrome://help, oops.)
4 years, 6 months ago (2016-06-24 18:01:07 UTC) #3
michaelpg
+jochen for chrome/browser OWNERS
4 years, 6 months ago (2016-06-24 18:02:16 UTC) #5
Dan Beam
still think it's a bummer to have to disable for all debug builder, but aight ...
4 years, 6 months ago (2016-06-24 18:30:23 UTC) #6
michaelpg
On 2016/06/24 18:30:23, Dan Beam wrote: > still think it's a bummer to have to ...
4 years, 6 months ago (2016-06-24 19:07:10 UTC) #7
michaelpg
s/jochen/thestig since it's saturday in europe
4 years, 6 months ago (2016-06-24 22:57:57 UTC) #9
Lei Zhang
lgtm
4 years, 6 months ago (2016-06-24 23:04:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2095043004/40001
4 years, 6 months ago (2016-06-24 23:06:14 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/234370)
4 years, 6 months ago (2016-06-25 00:17:24 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2095043004/40001
4 years, 6 months ago (2016-06-25 02:16:31 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-25 02:48:23 UTC) #19
commit-bot: I haz the power
4 years, 6 months ago (2016-06-25 02:49:41 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/98ae4c9db98d003b559a52692f6e3b7c374c67e4
Cr-Commit-Position: refs/heads/master@{#402045}

Powered by Google App Engine
This is Rietveld 408576698