Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(821)

Unified Diff: chrome/browser/browser_about_handler.cc

Issue 2095043004: Fix material Help page redirect, again (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: #YOLO Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/browser_about_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_about_handler.cc
diff --git a/chrome/browser/browser_about_handler.cc b/chrome/browser/browser_about_handler.cc
index 8ecad6cd93f751b406fb3853377f6c6b0ac30047..2865bbb7d79837bfebc2656fb2be9f5bf2d347ef 100644
--- a/chrome/browser/browser_about_handler.cc
+++ b/chrome/browser/browser_about_handler.cc
@@ -108,7 +108,8 @@ bool WillHandleBrowserAboutURL(GURL* url,
} else if (host == chrome::kChromeUIHelpHost) {
if (base::FeatureList::IsEnabled(
features::kMaterialDesignSettingsFeature)) {
- return true; // Prevent further rewriting - this is a valid URL.
+ host = chrome::kChromeUISettingsHost;
+ path = chrome::kChromeUIHelpHost;
} else if (::switches::AboutInSettingsEnabled()) {
host = chrome::kChromeUISettingsFrameHost;
if (url->path().empty() || url->path() == "/")
« no previous file with comments | « no previous file | chrome/browser/browser_about_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698