Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1212)

Issue 2094993002: Convert video-volume*, video-width* and viewport* tests to testharness.js (Closed)

Created:
4 years, 6 months ago by Srirama
Modified:
4 years, 6 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert video-volume*, video-width* and viewport* tests to testharness.js Cleaning up video-volume*, video-width* and viewport* tests in media/ to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/ba1f666447669a025c4a3aeadadd995c25f6f475 Cr-Commit-Position: refs/heads/master@{#402065}

Patch Set 1 : #

Total comments: 4

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -126 lines) Patch
M third_party/WebKit/LayoutTests/media/video-volume.html View 1 1 chunk +31 lines, -28 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-volume-expected.txt View 1 chunk +0 lines, -23 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/video-width-height.html View 1 chunk +25 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-width-height-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/viewport-in-standalone-media-document.html View 1 1 chunk +16 lines, -34 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/viewport-in-standalone-media-document-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Srirama
PTAL
4 years, 6 months ago (2016-06-24 12:45:27 UTC) #4
fs
lgtm https://codereview.chromium.org/2094993002/diff/20001/third_party/WebKit/LayoutTests/media/video-volume.html File third_party/WebKit/LayoutTests/media/video-volume.html (right): https://codereview.chromium.org/2094993002/diff/20001/third_party/WebKit/LayoutTests/media/video-volume.html#newcode23 third_party/WebKit/LayoutTests/media/video-volume.html:23: video.oncanplaythrough = t.step_func_done(function () { Nit: stray space ...
4 years, 6 months ago (2016-06-24 15:43:33 UTC) #5
Srirama
https://codereview.chromium.org/2094993002/diff/20001/third_party/WebKit/LayoutTests/media/video-volume.html File third_party/WebKit/LayoutTests/media/video-volume.html (right): https://codereview.chromium.org/2094993002/diff/20001/third_party/WebKit/LayoutTests/media/video-volume.html#newcode23 third_party/WebKit/LayoutTests/media/video-volume.html:23: video.oncanplaythrough = t.step_func_done(function () { On 2016/06/24 15:43:32, fs ...
4 years, 6 months ago (2016-06-25 14:39:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2094993002/80001
4 years, 6 months ago (2016-06-25 14:39:42 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:80001)
4 years, 6 months ago (2016-06-25 15:49:51 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-25 15:51:17 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ba1f666447669a025c4a3aeadadd995c25f6f475
Cr-Commit-Position: refs/heads/master@{#402065}

Powered by Google App Engine
This is Rietveld 408576698