third_party/WebKit/LayoutTests/media/viewport-in-standalone-media-document.html - Issue 2094993002: Convert video-volume*, video-width* and viewport* tests to testharness.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/viewport-in-standalone-media-document.html

Issue 2094993002: Convert video-volume*, video-width* and viewport* tests to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/media/video-volume.html ('K') | « third_party/WebKit/LayoutTests/media/video-width-height-expected.txt ('k') | third_party/WebKit/LayoutTests/media/viewport-in-standalone-media-document-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <title>This tests that a standalone media document has viewport settings.</title >

3 <head>	3 <script src="../resources/testharness.js"></script>

4 <script src="../media/media-file.js"></script>	4 <script src="../resources/testharnessreport.js"></script>

5 <!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956	5 <script src="media-file.js"></script>

6 (Please avoid writing new tests using video-test.js) -->	6 <iframe></iframe>

7 <script src="../media/video-test.js"></script>	7 <script>

8 <script>	8 async_test(function(t) {

9 var metaElement;	9 var skipOnFirstEmptyLoad = 0;

10 var standaloneMediaDocument;	10 var iframe = document.querySelector("iframe");

11 var skipOnFirstEmptyLoad = 0;

12	11

13 function frameLoaded()	12 iframe.onload = t.step_func_done(function() {
	fs 2016/06/24 15:43:32 Because we're skipping/ignoring the first event, s Because we're skipping/ignoring the first event, shouldn't this be a step_func with an explicit t.done()? Srirama 2016/06/25 14:39:25 Done. Now the event is fired only once as we set o Show quoted text On 2016/06/24 15:43:32, fs wrote: > Because we're skipping/ignoring the first event, shouldn't this be a step_func > with an explicit t.done()? Done. Now the event is fired only once as we set onload event a little late.
14 {	13 if (++skipOnFirstEmptyLoad == 1)

15 if (++skipOnFirstEmptyLoad == 1)	14 return;

16 return;

17	15

18 standaloneMediaDocument = document.getElementById("videoframe"). contentDocument;	16 var metaElement = iframe.contentDocument.querySelector("meta");

19 metaElement = standaloneMediaDocument.querySelector("meta");

20	17

21 testExpected("metaElement.name", "viewport");	18 assert_equals(metaElement.name, "viewport");

22 testExpected("metaElement.content", "width=device-width");	19 assert_equals(metaElement.content, "width=device-width");

	20 });

23	21

24 endTest();	22 iframe.src = findMediaFile("video", "content/test");

25 }	23 });

26 </script>	24 </script>

27 </head>

28 <body>

29 <p>

30 This tests that a standalone media document has viewport settings.

31 </p>

32 <iframe id="videoframe" onload="frameLoaded()"></iframe>

33 <script>

34 document.getElementById("videoframe").src = findMediaFile("video", " content/test");

35 </script>

36 </body>

37 </html>

OLD	NEW