Make base::Environment::Create() return unique_ptrs.

Make base::Environment::Create() return unique_ptrs.

BUG=581865
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng
TBR=jshin@chromium.org

Committed: https://crrev.com/0c412e85eb68bd357bb73ff3bc424b0d7f4dcb89
Cr-Commit-Position: refs/heads/master@{#403115}

[Lei Zhang, 2016-06-24 01:17:56]

Description was changed from

==========
Make base::Environment::Create() return unique_ptrs.

BUG=581865
==========

to

==========
Make base::Environment::Create() return unique_ptrs.

BUG=581865
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

[Lei Zhang, 2016-06-24 02:05:46]

Patchset #1 (id:1) has been deleted

[Lei Zhang, 2016-06-24 07:19:21]

Patchset #2 (id:40001) has been deleted

[Lei Zhang, 2016-06-24 07:19:27]

Patchset #1 (id:20001) has been deleted

[Lei Zhang, 2016-06-24 17:18:02]

thestig@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2016-06-24 17:28:35]

https://codereview.chromium.org/2094913002/diff/80001/base/environment.cc
File base/environment.cc (right):

https://codereview.chromium.org/2094913002/diff/80001/base/environment.cc#new...
base/environment.cc:139: return WrapUnique(new EnvironmentImpl());
Nit: base::MakeUnique<EnvironmentImpl>()?

https://codereview.chromium.org/2094913002/diff/80001/chrome/browser/shell_in...
File chrome/browser/shell_integration_linux_unittest.cc (right):

https://codereview.chromium.org/2094913002/diff/80001/chrome/browser/shell_in...
chrome/browser/shell_integration_linux_unittest.cc:69:
std::map<base::StringPiece, std::string> variables_;
It's not obvious that this is safe (or that it will be safe if the test changes
in the future), maybe it'd be safer to keep storing std::string in the map.

[Lei Zhang, 2016-06-24 18:56:03]

https://codereview.chromium.org/2094913002/diff/80001/base/environment.cc
File base/environment.cc (right):

https://codereview.chromium.org/2094913002/diff/80001/base/environment.cc#new...
base/environment.cc:139: return WrapUnique(new EnvironmentImpl());
On 2016/06/24 17:28:35, dcheng wrote:
> Nit: base::MakeUnique<EnvironmentImpl>()?

Done. (Already in namespace base)

https://codereview.chromium.org/2094913002/diff/80001/chrome/browser/shell_in...
File chrome/browser/shell_integration_linux_unittest.cc (right):

https://codereview.chromium.org/2094913002/diff/80001/chrome/browser/shell_in...
chrome/browser/shell_integration_linux_unittest.cc:69:
std::map<base::StringPiece, std::string> variables_;
On 2016/06/24 17:28:35, dcheng wrote:
> It's not obvious that this is safe (or that it will be safe if the test
changes
> in the future), maybe it'd be safer to keep storing std::string in the map.

Sure. I don't have strong feelings about creating some extra strings in unit
tests.

[Lei Zhang, 2016-06-24 18:59:19]

thestig@chromium.org changed reviewers:
+ rch@chromium.org, rickyz@chromium.org

[Lei Zhang, 2016-06-24 18:59:20]

Adding more reviewers:

rch: net/
rickyz: sandbox/

[rickyz (no longer on Chrome), 2016-06-24 20:43:22]

sandbox/linux lgtm, thanks for the misc style fixes too!

[dcheng, 2016-06-24 21:14:41]

lgtm

[Lei Zhang, 2016-06-24 21:59:41]

Description was changed from

==========
Make base::Environment::Create() return unique_ptrs.

BUG=581865
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

to

==========
Make base::Environment::Create() return unique_ptrs.

BUG=581865
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng
TBR=jshin@chromium.org
==========

[Lei Zhang, 2016-06-24 21:59:41]

thestig@chromium.org changed reviewers:
+ jshin@chromium.org

[Ryan Hamilton, 2016-06-28 22:53:05]

net/ LGTM

https://codereview.chromium.org/2094913002/diff/100001/net/proxy/proxy_config...
File net/proxy/proxy_config_service_linux.h (right):

https://codereview.chromium.org/2094913002/diff/100001/net/proxy/proxy_config...
net/proxy/proxy_config_service_linux.h:169: // Noraml constructor.
nit: Normal

[Lei Zhang, 2016-06-28 23:10:55]

https://codereview.chromium.org/2094913002/diff/100001/net/proxy/proxy_config...
File net/proxy/proxy_config_service_linux.h (right):

https://codereview.chromium.org/2094913002/diff/100001/net/proxy/proxy_config...
net/proxy/proxy_config_service_linux.h:169: // Noraml constructor.
On 2016/06/28 22:53:05, Ryan Hamilton wrote:
> nit: Normal

Done.

[Lei Zhang, 2016-06-28 23:11:01]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2016-06-28 23:11:01]

The patchset sent to the CQ was uploaded after l-g-t-m from rickyz@chromium.org,
rch@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2094913002/#ps120001
(title: "nit, rebase")

[commit-bot: I haz the power, 2016-06-28 23:12:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 01:37:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-29 01:37:11]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Lei Zhang, 2016-06-30 06:13:50]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-06-30 06:14:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 07:28:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 07:28:24]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Lei Zhang, 2016-06-30 07:30:53]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-06-30 07:31:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 08:04:52]

Description was changed from

==========
Make base::Environment::Create() return unique_ptrs.

BUG=581865
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng
TBR=jshin@chromium.org
==========

to

==========
Make base::Environment::Create() return unique_ptrs.

BUG=581865
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng
TBR=jshin@chromium.org
==========

[commit-bot: I haz the power, 2016-06-30 08:04:54]

Committed patchset #4 (id:120001)

[commit-bot: I haz the power, 2016-06-30 08:04:57]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-30 08:06:07]

Description was changed from

==========
Make base::Environment::Create() return unique_ptrs.

BUG=581865
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng
TBR=jshin@chromium.org
==========

to

==========
Make base::Environment::Create() return unique_ptrs.

BUG=581865
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng
TBR=jshin@chromium.org

Committed: https://crrev.com/0c412e85eb68bd357bb73ff3bc424b0d7f4dcb89
Cr-Commit-Position: refs/heads/master@{#403115}
==========

[commit-bot: I haz the power, 2016-06-30 08:06:08]

Patchset 4 (id:??) landed as
https://crrev.com/0c412e85eb68bd357bb73ff3bc424b0d7f4dcb89
Cr-Commit-Position: refs/heads/master@{#403115}