ui/base/l10n/l10n_util_unittest.cc - Issue 2094913002: Make base::Environment::Create() return unique_ptrs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/l10n/l10n_util_unittest.cc

Issue 2094913002: Make base::Environment::Create() return unique_ptrs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit, rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/base/l10n/l10n_util_unittest.cc

diff --git a/ui/base/l10n/l10n_util_unittest.cc b/ui/base/l10n/l10n_util_unittest.cc

index 524980456fe3f9146299fb6103ffee45f49efa09..f4ff97cacf39628947b1298dc276adf9fed7b27c 100644

--- a/ui/base/l10n/l10n_util_unittest.cc

+++ b/ui/base/l10n/l10n_util_unittest.cc

@@ -136,7 +136,7 @@ TEST_F(L10nUtilTest, GetAppLocale) {

const std::string original_locale = base::i18n::GetConfiguredLocale();

if (kPlatformHasDefaultLocale && kUseLocaleFromEnvironment) {

- env.reset(base::Environment::Create());

+ env = base::Environment::Create();

// Test the support of LANGUAGE environment variable.

base::i18n::SetICUDefaultLocale("en-US");

« no previous file with comments | « sandbox/win/src/address_sanitizer_test.cc ('k') | no next file » | no next file with comments »