[Devtools] Fixed websocket initiators

[Devtools] Fixed websocket initiators

BUG=457811
R=dgozman

Committed: https://crrev.com/b08177119dcdbf407492ca84065a6cff32fd78b0
Committed: https://crrev.com/4e653282894bd517eb69156e0af350d26e045882
Cr-Original-Commit-Position: refs/heads/master@{#402313}
Cr-Commit-Position: refs/heads/master@{#403398}

[allada, 2016-06-24 00:15:15]

Patchset #1 (id:1) has been deleted

[allada, 2016-06-24 00:17:45]

Patchset #1 (id:20001) has been deleted

[allada, 2016-06-24 00:17:57]

PTL

[dgozman, 2016-06-24 20:21:03]

I like this!

https://codereview.chromium.org/2094903002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp (right):

https://codereview.chromium.org/2094903002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp:825:
DCHECK(currentStackTrace);
This DCHECK looks suspicious. What if websocket was initiated from native? Can
we replay it, for example?
I think we should make initiator optional.

[allada, 2016-06-27 18:06:06]

PTL

[allada, 2016-06-27 19:14:43]

Description was changed from

==========
[Devtools] Fixed websocket initiators

Fixed initiators for websockets.

BUG=457811
R=dgozman
==========

to

==========
[Devtools] Fixed websocket initiators

BUG=457811
R=dgozman
==========

[dgozman, 2016-06-27 19:14:50]

lgtm

https://codereview.chromium.org/2094903002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js (right):

https://codereview.chromium.org/2094903002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js:463: var
networkRequest = new WebInspector.NetworkRequest(this._manager._target,
requestId, requestURL, "", "", "", initiator ? initiator : null);
nit: initiator || null

[allada, 2016-06-27 19:19:57]

The CQ bit was checked by allada@chromium.org

[allada, 2016-06-27 19:19:58]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2094903002/#ps100001
(title: "Fixed suggestions")

[commit-bot: I haz the power, 2016-06-27 19:20:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 22:23:36]

Description was changed from

==========
[Devtools] Fixed websocket initiators

BUG=457811
R=dgozman
==========

to

==========
[Devtools] Fixed websocket initiators

BUG=457811
R=dgozman
==========

[commit-bot: I haz the power, 2016-06-27 22:23:37]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2016-06-27 22:25:12]

Description was changed from

==========
[Devtools] Fixed websocket initiators

BUG=457811
R=dgozman
==========

to

==========
[Devtools] Fixed websocket initiators

BUG=457811
R=dgozman

Committed: https://crrev.com/b08177119dcdbf407492ca84065a6cff32fd78b0
Cr-Commit-Position: refs/heads/master@{#402313}
==========

[commit-bot: I haz the power, 2016-06-27 22:25:13]

Patchset 4 (id:??) landed as
https://crrev.com/b08177119dcdbf407492ca84065a6cff32fd78b0
Cr-Commit-Position: refs/heads/master@{#402313}

[tkent, 2016-06-28 08:01:10]

A revert of this CL (patchset #4 id:100001) has been created in
https://codereview.chromium.org/2102003002/ by tkent@chromium.org.

The reason for reverting is: The test is very flaky.
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=ins...
.

[allada, 2016-06-29 18:15:12]

Please review Test for flakiness.

https://codereview.chromium.org/2094903002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js (right):

https://codereview.chromium.org/2094903002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js:463: var
networkRequest = new WebInspector.NetworkRequest(this._manager._target,
requestId, requestURL, "", "", "", initiator ? initiator : null);
On 2016/06/27 19:14:50, dgozman wrote:
> nit: initiator || null

Done.

[allada, 2016-06-29 18:15:24]

Description was changed from

==========
[Devtools] Fixed websocket initiators

BUG=457811
R=dgozman

Committed: https://crrev.com/b08177119dcdbf407492ca84065a6cff32fd78b0
Cr-Commit-Position: refs/heads/master@{#402313}
==========

to

==========
[Devtools] Fixed websocket initiators

BUG=457811
R=dgozman

Committed: https://crrev.com/b08177119dcdbf407492ca84065a6cff32fd78b0
Cr-Commit-Position: refs/heads/master@{#402313}
==========

[allada, 2016-06-30 17:43:59]

The CQ bit was checked by allada@chromium.org

[allada, 2016-06-30 17:44:00]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2094903002/#ps120001
(title: "Fixed flaky test")

[commit-bot: I haz the power, 2016-06-30 17:44:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 19:54:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 19:54:02]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[allada, 2016-07-01 00:02:49]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-01 00:03:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[allada, 2016-07-01 02:04:10]

The CQ bit was checked by allada@chromium.org

[allada, 2016-07-01 02:04:10]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2094903002/#ps140001
(title: "More Flaky fixes")

[commit-bot: I haz the power, 2016-07-01 02:04:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 03:23:32]

Description was changed from

==========
[Devtools] Fixed websocket initiators

BUG=457811
R=dgozman

Committed: https://crrev.com/b08177119dcdbf407492ca84065a6cff32fd78b0
Cr-Commit-Position: refs/heads/master@{#402313}
==========

to

==========
[Devtools] Fixed websocket initiators

BUG=457811
R=dgozman

Committed: https://crrev.com/b08177119dcdbf407492ca84065a6cff32fd78b0
Cr-Commit-Position: refs/heads/master@{#402313}
==========

[commit-bot: I haz the power, 2016-07-01 03:23:33]

Committed patchset #6 (id:140001)

[commit-bot: I haz the power, 2016-07-01 03:26:21]

Description was changed from

==========
[Devtools] Fixed websocket initiators

BUG=457811
R=dgozman

Committed: https://crrev.com/b08177119dcdbf407492ca84065a6cff32fd78b0
Cr-Commit-Position: refs/heads/master@{#402313}
==========

to

==========
[Devtools] Fixed websocket initiators

BUG=457811
R=dgozman

Committed: https://crrev.com/b08177119dcdbf407492ca84065a6cff32fd78b0
Committed: https://crrev.com/4e653282894bd517eb69156e0af350d26e045882
Cr-Original-Commit-Position: refs/heads/master@{#402313}
Cr-Commit-Position: refs/heads/master@{#403398}
==========

[commit-bot: I haz the power, 2016-07-01 03:26:22]

Patchset 6 (id:??) landed as
https://crrev.com/4e653282894bd517eb69156e0af350d26e045882
Cr-Commit-Position: refs/heads/master@{#403398}