Issue 2094843002: Scale menu position back to viewport in pepper plugin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2094843002: Scale menu position back to viewport in pepper plugin (Closed)

Created:
4 years, 6 months ago by oshima

Modified:
4 years, 6 months ago

Reviewers:

CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2743

Target Ref:
refs/pending/branch-heads/2743

Project:
chromium

Visibility:
Public.

Scale menu position back to viewport in pepper plugin pepper uses DIP, so it needs to be converted to viewport in use-zoom-for-dsf mode. BUG=621943, 485650 TEST=manual Review-Url: https://codereview.chromium.org/2082893003 Cr-Commit-Position: refs/heads/master@{#401024} (cherry picked from commit 9373922b7d01101f232c6ccfdedefd76e338e3ab) Committed: https://chromium.googlesource.com/chromium/src/+/8943b97229c51f6ef0e1eb036089e9b68eff5cf7

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -2 lines)			Patch
M	content/renderer/pepper/pepper_plugin_instance_impl.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/renderer/pepper/renderer_ppapi_host_impl.h	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	content/renderer/pepper/renderer_ppapi_host_impl.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download

Total messages: 2 (1 generated)

oshima

4 years, 6 months ago (2016-06-23 20:51:07 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8943b97229c51f6ef0e1eb036089e9b68eff5cf7.