Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2082893003: Scale menu position back to viewport in pepper plugin (Closed)

Created:
4 years, 6 months ago by oshima
Modified:
4 years, 6 months ago
Reviewers:
bbudge
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Scale menu position back to viewport in pepper plugin pepper uses DIP, so it needs to be converted to viewport in use-zoom-for-dsf mode. BUG=621943, 485650 TEST=manual Committed: https://crrev.com/9373922b7d01101f232c6ccfdedefd76e338e3ab Cr-Commit-Position: refs/heads/master@{#401024}

Patch Set 1 : Adjust menu position in pepper plugin #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/pepper/renderer_ppapi_host_impl.h View 2 chunks +8 lines, -0 lines 0 comments Download
M content/renderer/pepper/renderer_ppapi_host_impl.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082893003/20001
4 years, 6 months ago (2016-06-21 15:12:51 UTC) #7
oshima
4 years, 6 months ago (2016-06-21 15:31:22 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-21 15:58:34 UTC) #10
bbudge
lgtm
4 years, 6 months ago (2016-06-21 17:06:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2082893003/20001
4 years, 6 months ago (2016-06-21 17:20:21 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 6 months ago (2016-06-21 17:25:35 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 17:49:37 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9373922b7d01101f232c6ccfdedefd76e338e3ab
Cr-Commit-Position: refs/heads/master@{#401024}

Powered by Google App Engine
This is Rietveld 408576698