Issue 209483003: Merge 256634 "Show dialog as separate post task."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 209483003: Merge 256634 "Show dialog as separate post task." (Closed)

Created:
6 years, 9 months ago by Vitaly Buka (NO REVIEWS)

Modified:
6 years, 9 months ago

Reviewers:
Vitaly Buka (NO REVIEWS)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/branches/1847/src/

Visibility:
Public.

Merge 256634 "Show dialog as separate post task." > Show dialog as separate post task. > Dialog runs nested loop and can destroy data necessary for caller. > > BUG=350537 > > Review URL: https://codereview.chromium.org/194383002 TBR=vitalybuka@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258824

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -11 lines)			Patch
M	chrome/browser/printing/print_error_dialog.h	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/printing/print_error_dialog.cc	View	1 chunk	+17 lines, -2 lines	0 comments	Download
M	chrome/browser/printing/print_view_manager_base.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview/print_preview_handler.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

Vitaly Buka (NO REVIEWS)

6 years, 9 months ago (2014-03-23 05:05:41 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r258824 (tree was closed).