Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 194383002: Show dialog as separate post task. (Closed)

Created:
6 years, 9 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 9 months ago
Reviewers:
Noam Samuel
CC:
chromium-reviews
Visibility:
Public.

Description

Show dialog as separate post task. Dialog runs nested loop and can destroy data necessary for caller. BUG=350537 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256634

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -11 lines) Patch
M chrome/browser/printing/print_error_dialog.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/printing/print_error_dialog.cc View 1 1 chunk +17 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_view_manager_base.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 1 2 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 9 months ago (2014-03-11 06:21:23 UTC) #1
Noam Samuel
lgtm Also, if we show this dialog for native print errors, we should probably do ...
6 years, 9 months ago (2014-03-11 17:30:03 UTC) #2
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 9 months ago (2014-03-11 17:56:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/194383002/1
6 years, 9 months ago (2014-03-11 18:00:57 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-11 21:53:14 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=279820
6 years, 9 months ago (2014-03-11 21:53:15 UTC) #6
Noam Samuel
The CQ bit was checked by noamsml@chromium.org
6 years, 9 months ago (2014-03-11 22:04:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/194383002/1
6 years, 9 months ago (2014-03-11 22:32:49 UTC) #8
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 9 months ago (2014-03-11 23:33:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/194383002/60001
6 years, 9 months ago (2014-03-11 23:34:18 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-12 03:21:00 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg, mac_chromium_rel
6 years, 9 months ago (2014-03-12 03:21:00 UTC) #12
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 9 months ago (2014-03-12 06:43:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/194383002/80001
6 years, 9 months ago (2014-03-12 06:44:10 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-12 09:59:17 UTC) #15
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) ash_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=280407
6 years, 9 months ago (2014-03-12 09:59:18 UTC) #16
Noam Samuel
The CQ bit was checked by noamsml@chromium.org
6 years, 9 months ago (2014-03-12 17:10:03 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/194383002/80001
6 years, 9 months ago (2014-03-12 17:14:12 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/194383002/80001
6 years, 9 months ago (2014-03-12 19:23:18 UTC) #19
commit-bot: I haz the power
6 years, 9 months ago (2014-03-12 20:43:59 UTC) #20
Message was sent while issue was closed. 
Change committed as 256634

Powered by Google App Engine
This is Rietveld 408576698