gl_unittests: on a core profile, use VAOs

ui/gl/gl_helper.cc

Index: ui/gl/gl_helper.cc
diff --git a/ui/gl/gl_helper.cc b/ui/gl/gl_helper.cc
index 97a4e3b76f57be363ef6b289c827b383236b700a..abcab00a0aa1ed0480dfb7a45c76ee0ba08a8114 100644
--- a/ui/gl/gl_helper.cc
+++ b/ui/gl/gl_helper.cc
@@ -7,6 +7,8 @@
 #include <string>
 
 #include "base/logging.h"
+#include "ui/gl/gl_implementation.h"
+#include "ui/gl/gl_version_info.h"
 #include "ui/gl/scoped_binders.h"
 
 namespace gl {
@@ -94,4 +96,14 @@ void GLHelper::DrawQuad(GLuint vertex_buffer) {
   glDrawArrays(GL_TRIANGLE_STRIP, 0, 4);
 }
 
+// static
+bool GLHelper::ShouldTestsUseVAOs() {

[Corentin Wallez, 2016/06/23 20:00:04]

AFAIK, after the GLContextGLX change this will always be true because
gl_unittests run on OSMesa. That plus OSMesa's 3.0 context having VAOs could
lead to a simplification where we just use VAOs and don't bother with this
helper function. What do you think?

[piman, 2016/06/23 20:09:01]

I think we still run the tests on GLES 2.0 (e.g. Android, Chrome OS), so let's
leave this for now.

+  auto version = reinterpret_cast<const char*>(glGetString(GL_VERSION));
+  auto renderer = reinterpret_cast<const char*>(glGetString(GL_RENDERER));
+  auto extensions = gl::GetGLExtensionsFromCurrentContext();
+
+  return GLVersionInfo(version, renderer, extensions.c_str())

[piman, 2016/06/23 20:09:01]

nit: you should be able to use GLContext::GetCurrent()->GetVersionInfo() instead
of reconstructing it.

+      .is_desktop_core_profile;
+}
+
 }  // namespace gl