gl_unittests: on a core profile, use VAOs

ui/gl/gl_helper.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gl/gl_helper.h"
 
 #include <string>
 
 #include "base/logging.h"
+#include "ui/gl/gl_implementation.h"
+#include "ui/gl/gl_version_info.h"
 #include "ui/gl/scoped_binders.h"
 
 namespace gl {
 
 // static
 GLuint GLHelper::CompileShader(GLenum type, const char* src) {
   GLuint shader = glCreateShader(type);
   // Load the shader source.
   glShaderSource(shader, 1, &src, nullptr);
   // Compile the shader.
@@ skipping 67 matching lines @@
   ScopedCapability disable_blending(GL_BLEND, GL_FALSE);
   ScopedCapability disable_culling(GL_CULL_FACE, GL_FALSE);
   ScopedCapability disable_dithering(GL_DITHER, GL_FALSE);
   ScopedCapability disable_depth_test(GL_DEPTH_TEST, GL_FALSE);
   ScopedCapability disable_scissor_test(GL_SCISSOR_TEST, GL_FALSE);
   ScopedColorMask color_mask(GL_TRUE, GL_TRUE, GL_TRUE, GL_TRUE);
 
   glDrawArrays(GL_TRIANGLE_STRIP, 0, 4);
 }
 
+// static
+bool GLHelper::ShouldTestsUseVAOs() {

[Corentin Wallez, 2016/06/23 20:00:04]

AFAIK, after the GLContextGLX change this will always be true because
gl_unittests run on OSMesa. That plus OSMesa's 3.0 context having VAOs could
lead to a simplification where we just use VAOs and don't bother with this
helper function. What do you think?

[piman, 2016/06/23 20:09:01]

I think we still run the tests on GLES 2.0 (e.g. Android, Chrome OS), so let's
leave this for now.

+  auto version = reinterpret_cast<const char*>(glGetString(GL_VERSION));
+  auto renderer = reinterpret_cast<const char*>(glGetString(GL_RENDERER));
+  auto extensions = gl::GetGLExtensionsFromCurrentContext();
+
+  return GLVersionInfo(version, renderer, extensions.c_str())

[piman, 2016/06/23 20:09:01]

nit: you should be able to use GLContext::GetCurrent()->GetVersionInfo() instead
of reconstructing it.

+      .is_desktop_core_profile;
+}
+
 }  // namespace gl