Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3558)

Unified Diff: chrome/browser/resources/settings/site_settings_page/site_settings_page.html

Issue 2094813002: MD Settings: make custom UIs look "actionable" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/site_settings_page/site_settings_page.html
diff --git a/chrome/browser/resources/settings/site_settings_page/site_settings_page.html b/chrome/browser/resources/settings/site_settings_page/site_settings_page.html
index e808bc1ac7785e249af0a5b3c27f28ccf38b0d31..6e8ea51ce672cd9cf69c83c7cddff9cd5788feef 100644
--- a/chrome/browser/resources/settings/site_settings_page/site_settings_page.html
+++ b/chrome/browser/resources/settings/site_settings_page/site_settings_page.html
@@ -8,14 +8,13 @@
<dom-module id="settings-site-settings-page">
<template>
- <style include="settings-shared">
- </style>
- <div class="settings-box first" category$="[[ALL_SITES]]"
+ <style include="settings-shared"></style>
+ <div class="settings-box first" category$="[[ALL_SITES]]" actionable
on-tap="onTapCategory">
<iron-icon icon="settings:list"></iron-icon>
<div class="middle">$i18n{siteSettingsCategoryAllSites}</div>
</div>
- <div class="settings-box two-line"
+ <div class="settings-box two-line" actionable
category$="[[ContentSettingsTypes.COOKIES]]" on-tap="onTapCategory">
<iron-icon icon="[[computeIconForContentCategory(
ContentSettingsTypes.COOKIES)]]"></iron-icon>
@@ -26,7 +25,7 @@
<div id="cookies" class="secondary"></div>
</div>
</div>
- <div class="settings-box two-line"
+ <div class="settings-box two-line" actionable
category$="[[ContentSettingsTypes.GEOLOCATION]]" on-tap="onTapCategory">
<iron-icon icon="[[computeIconForContentCategory(
ContentSettingsTypes.GEOLOCATION)]]" item-icon=""></iron-icon>
@@ -35,7 +34,7 @@
<div id="geolocation" class="secondary"></div>
</div>
</div>
- <div class="settings-box two-line"
+ <div class="settings-box two-line" actionable
category$="[[ContentSettingsTypes.CAMERA]]" on-tap="onTapCategory">
<iron-icon icon="[[computeIconForContentCategory(
ContentSettingsTypes.CAMERA)]]" item-icon=""></iron-icon>
@@ -45,7 +44,7 @@
</div>
</div>
<div class="settings-box two-line" category$="[[ContentSettingsTypes.MIC]]"
- on-tap="onTapCategory">
+ on-tap="onTapCategory" actionable>
<iron-icon icon="[[computeIconForContentCategory(
ContentSettingsTypes.MIC)]]" item-icon=""></iron-icon>
<div class="middle">
@@ -53,7 +52,7 @@
<div id="mic" class="secondary"></div>
</div>
</div>
- <div class="settings-box two-line"
+ <div class="settings-box two-line" actionable
category$="[[ContentSettingsTypes.NOTIFICATIONS]]"
on-tap="onTapCategory">
<iron-icon icon="[[computeIconForContentCategory(
@@ -63,7 +62,7 @@
<div id="notifications" class="secondary"></div>
</div>
</div>
- <div class="settings-box two-line"
+ <div class="settings-box two-line" actionable
category$="[[ContentSettingsTypes.JAVASCRIPT]]"
on-tap="onTapCategory">
<iron-icon icon="[[computeIconForContentCategory(
@@ -73,7 +72,7 @@
<div id="javascript" class="secondary"></div>
</div>
</div>
- <div class="settings-box two-line"
+ <div class="settings-box two-line" actionable
category$="[[ContentSettingsTypes.PLUGINS]]"
on-tap="onTapCategory">
<iron-icon icon="[[computeIconForContentCategory(
@@ -83,7 +82,7 @@
<div id="plugins" class="secondary"></div>
</div>
</div>
- <div class="settings-box two-line"
+ <div class="settings-box two-line" actionable
category$="[[ContentSettingsTypes.IMAGES]]" on-tap="onTapCategory">
<iron-icon icon="[[computeIconForContentCategory(
ContentSettingsTypes.IMAGES)]]" item-icon=""></iron-icon>
@@ -92,7 +91,7 @@
<div id="images" class="secondary"></div>
</div>
</div>
- <div class="settings-box two-line"
+ <div class="settings-box two-line" actionable
category$="[[ContentSettingsTypes.POPUPS]]" on-tap="onTapCategory">
<iron-icon icon="[[computeIconForContentCategory(
ContentSettingsTypes.POPUPS)]]" item-icon=""></iron-icon>
@@ -101,7 +100,7 @@
<div id="popups" class="secondary"></div>
</div>
</div>
- <div class="settings-box two-line"
+ <div class="settings-box two-line" actionable
category$="[[ContentSettingsTypes.BACKGROUND_SYNC]]"
on-tap="onTapCategory">
<iron-icon icon="[[computeIconForContentCategory(
@@ -112,7 +111,7 @@
<div id="backgroundSync" class="secondary"></div>
</div>
</div>
- <div class="settings-box two-line"
+ <div class="settings-box two-line" actionable
category$="[[ContentSettingsTypes.KEYGEN]]"
on-tap="onTapCategory">
<iron-icon icon="[[computeIconForContentCategory(
@@ -123,7 +122,7 @@
<div id="keygen" class="secondary"></div>
</div>
</div>
- <div class="settings-box two-line"
+ <div class="settings-box two-line" actionable
category$="[[ContentSettingsTypes.AUTOMATIC_DOWNLOADS]]"
on-tap="onTapCategory">
<iron-icon icon="[[computeIconForContentCategory(
@@ -134,7 +133,7 @@
<div id="automaticDownloads" class="secondary"></div>
</div>
</div>
- <div class="settings-box two-line"
+ <div class="settings-box two-line" actionable
category$="[[ContentSettingsTypes.UNSANDBOXED_PLUGINS]]"
on-tap="onTapCategory">
<iron-icon icon="[[computeIconForContentCategory(

Powered by Google App Engine
This is Rietveld 408576698