Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2094803005: Fix PrepareTextureCopyOutputResult to avoid ScopedCallbackRunner. (Closed)

Created:
4 years, 6 months ago by Sergey Ulanov
Modified:
4 years, 5 months ago
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@move_closure_runner
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix incorrect usage of ScopedCallbackRunner.Reset(). ScopedCallbackRunner.Reset() was used in two places with assumption it doesn't call current callback. Replaced Reset() with ReplaceClosure() and RunAndReset() to make behavior clearer. Committed: https://crrev.com/668613aa8ef226fd280cbd686654bad521222422 Cr-Commit-Position: refs/heads/master@{#404277}

Patch Set 1 #

Total comments: 2

Patch Set 2 : renamed Reset #

Patch Set 3 : . #

Patch Set 4 : RunNow #

Total comments: 6

Patch Set 5 : address feedback #

Patch Set 6 : RunNow in destructor #

Patch Set 7 : revert to PatchSet 5 #

Total comments: 2

Patch Set 8 : RunAndReset #

Total comments: 2

Patch Set 9 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -46 lines) Patch
M base/callback_helpers.h View 1 2 3 4 5 6 7 1 chunk +5 lines, -5 lines 0 comments Download
M base/callback_helpers.cc View 1 2 3 4 5 6 7 1 chunk +3 lines, -6 lines 0 comments Download
M base/callback_helpers_unittest.cc View 1 2 3 4 5 6 7 4 chunks +22 lines, -32 lines 0 comments Download
M chrome/browser/install_verification/win/module_list_unittest.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M content/browser/compositor/surface_utils.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 57 (27 generated)
Sergey Ulanov
IMO it's best to get rid of ScopedClosureRunner::Reset() to avoid issues like this. This was ...
4 years, 6 months ago (2016-06-24 23:53:00 UTC) #2
danakj
https://codereview.chromium.org/2094803005/diff/1/content/browser/compositor/surface_utils.cc File content/browser/compositor/surface_utils.cc (left): https://codereview.chromium.org/2094803005/diff/1/content/browser/compositor/surface_utils.cc#oldcode79 content/browser/compositor/surface_utils.cc:79: scoped_callback_runner.Reset(base::Bind( Wait this actually want to call two callbacks, ...
4 years, 6 months ago (2016-06-24 23:57:27 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2094803005/40001
4 years, 6 months ago (2016-06-25 05:53:09 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2094803005/60001
4 years, 6 months ago (2016-06-25 06:01:21 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/26713)
4 years, 6 months ago (2016-06-25 06:12:00 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2094803005/80001
4 years, 6 months ago (2016-06-25 17:30:34 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/191777)
4 years, 6 months ago (2016-06-25 17:57:57 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2094803005/100001
4 years, 5 months ago (2016-06-27 18:30:22 UTC) #20
Sergey Ulanov
PTAL. Replaced Reset() with RunNow() and ReplaceClosure() now. https://codereview.chromium.org/2094803005/diff/1/content/browser/compositor/surface_utils.cc File content/browser/compositor/surface_utils.cc (left): https://codereview.chromium.org/2094803005/diff/1/content/browser/compositor/surface_utils.cc#oldcode79 content/browser/compositor/surface_utils.cc:79: scoped_callback_runner.Reset(base::Bind( ...
4 years, 5 months ago (2016-06-27 19:41:05 UTC) #22
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-27 20:08:57 UTC) #24
danakj
https://codereview.chromium.org/2094803005/diff/100001/base/callback_helpers.h File base/callback_helpers.h (right): https://codereview.chromium.org/2094803005/diff/100001/base/callback_helpers.h#newcode40 base/callback_helpers.h:40: // Releases the current closure if it's set and ...
4 years, 5 months ago (2016-06-27 22:49:57 UTC) #25
Sergey Ulanov
https://codereview.chromium.org/2094803005/diff/100001/base/callback_helpers.h File base/callback_helpers.h (right): https://codereview.chromium.org/2094803005/diff/100001/base/callback_helpers.h#newcode40 base/callback_helpers.h:40: // Releases the current closure if it's set and ...
4 years, 5 months ago (2016-06-28 19:15:57 UTC) #26
Sergey Ulanov
Also now changed the destructor to call RunNow() instead of calling closure_ directly. RunNow() moves ...
4 years, 5 months ago (2016-06-28 19:20:21 UTC) #27
Sergey Ulanov
On 2016/06/28 19:20:21, Sergey Ulanov wrote: > Also now changed the destructor to call RunNow() ...
4 years, 5 months ago (2016-06-28 19:29:44 UTC) #28
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2094803005/160001
4 years, 5 months ago (2016-06-28 19:30:48 UTC) #30
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/184670) linux_chromium_chromeos_compile_dbg_ng on ...
4 years, 5 months ago (2016-06-28 19:46:57 UTC) #32
danakj
LGTM https://codereview.chromium.org/2094803005/diff/160001/base/callback_helpers.h File base/callback_helpers.h (right): https://codereview.chromium.org/2094803005/diff/160001/base/callback_helpers.h#newcode45 base/callback_helpers.h:45: void RunNow(); nit: I think just "Run" would ...
4 years, 5 months ago (2016-06-28 20:02:15 UTC) #33
Sergey Ulanov
+sievers@chromium.org for content/browser/renderer_host/render_widget_host_view_android.cc +robertshield@chromium.org for chrome/browser/install_verification/win/module_list_unittest.cc https://codereview.chromium.org/2094803005/diff/160001/base/callback_helpers.h File base/callback_helpers.h (right): https://codereview.chromium.org/2094803005/diff/160001/base/callback_helpers.h#newcode45 base/callback_helpers.h:45: void RunNow(); On ...
4 years, 5 months ago (2016-06-28 23:51:34 UTC) #36
robertshield
chrome/browser/install_verification/win/module_list_unittest.cc LGTM
4 years, 5 months ago (2016-06-29 00:13:03 UTC) #37
Sergey Ulanov
sievers@: ping
4 years, 5 months ago (2016-07-01 21:45:49 UTC) #38
no sievers
lgtm https://codereview.chromium.org/2094803005/diff/180001/content/browser/compositor/surface_utils.cc File content/browser/compositor/surface_utils.cc (right): https://codereview.chromium.org/2094803005/diff/180001/content/browser/compositor/surface_utils.cc#newcode79 content/browser/compositor/surface_utils.cc:79: scoped_callback_runner.ReplaceClosure(base::Bind( Ah so |callback| ended up getting called ...
4 years, 5 months ago (2016-07-06 19:12:14 UTC) #39
Sergey Ulanov
https://codereview.chromium.org/2094803005/diff/180001/content/browser/compositor/surface_utils.cc File content/browser/compositor/surface_utils.cc (right): https://codereview.chromium.org/2094803005/diff/180001/content/browser/compositor/surface_utils.cc#newcode79 content/browser/compositor/surface_utils.cc:79: scoped_callback_runner.ReplaceClosure(base::Bind( On 2016/07/06 19:12:13, sievers wrote: > Ah so ...
4 years, 5 months ago (2016-07-06 19:13:32 UTC) #40
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2094803005/180001
4 years, 5 months ago (2016-07-06 19:14:17 UTC) #43
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/240662)
4 years, 5 months ago (2016-07-06 19:43:32 UTC) #45
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2094803005/200001
4 years, 5 months ago (2016-07-07 20:47:26 UTC) #48
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
4 years, 5 months ago (2016-07-07 22:49:13 UTC) #50
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2094803005/200001
4 years, 5 months ago (2016-07-07 23:50:20 UTC) #52
commit-bot: I haz the power
Committed patchset #9 (id:200001)
4 years, 5 months ago (2016-07-08 00:34:41 UTC) #54
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 00:34:52 UTC) #55
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 00:36:50 UTC) #57
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/668613aa8ef226fd280cbd686654bad521222422
Cr-Commit-Position: refs/heads/master@{#404277}

Powered by Google App Engine
This is Rietveld 408576698