Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Unified Diff: base/callback_helpers.cc

Issue 2094803005: Fix PrepareTextureCopyOutputResult to avoid ScopedCallbackRunner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_closure_runner
Patch Set: . Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/callback_helpers.h ('k') | base/callback_helpers_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/callback_helpers.cc
diff --git a/base/callback_helpers.cc b/base/callback_helpers.cc
index 8fd3dde6ca49089e9e4cc66e0089706f902ae678..838e6c8d849526076de0a72a63df5feda0c6e0cb 100644
--- a/base/callback_helpers.cc
+++ b/base/callback_helpers.cc
@@ -23,21 +23,18 @@ ScopedClosureRunner::ScopedClosureRunner(ScopedClosureRunner&& other)
ScopedClosureRunner& ScopedClosureRunner::operator=(
ScopedClosureRunner&& other) {
- Reset(other.Release());
+ ReplaceClosure(other.Release());
return *this;
}
-void ScopedClosureRunner::Reset() {
+void ScopedClosureRunner::RunAndReset() {
Closure old_closure = Release();
if (!old_closure.is_null())
old_closure.Run();
}
-void ScopedClosureRunner::Reset(const Closure& closure) {
- Closure old_closure = Release();
+void ScopedClosureRunner::ReplaceClosure(const Closure& closure) {
closure_ = closure;
- if (!old_closure.is_null())
- old_closure.Run();
}
Closure ScopedClosureRunner::Release() {
« no previous file with comments | « base/callback_helpers.h ('k') | base/callback_helpers_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698