Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2094783003:
Flip mac full builders to GN. (Closed)
|
Created:
4 years, 6 months ago by Dirk Pranke Modified:
4 years, 6 months ago CC:
chromium-reviews, chromoting-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFlip mac full builders to GN.
This flips the 'Mac' build on the 'chromium' waterfall and the
'Google Chrome Mac' build on the 'chromium.chrome' waterfall to GN.
If this sticks overnight, we can try to flip the official builders
to GN in the morning. This also flips the 'mac_chromium_archive_rel_ng'
MB config to match the 'Mac' config so that we can test builds more
effectively.
The official build still isn't "right", since we haven't ported over
the installer for the remoting me2me host. I'm going to try and work
around that for now so that we can see what else might be missing.
R=rsesek@chromium.org
TBR=zijiehe@chromium.org, sergeyu@chromium.org
BUG=618468
Committed: https://crrev.com/63619254507db98dec507b02a4ac09a9a4629009
Cr-Commit-Position: refs/heads/master@{#401894}
Patch Set 1 #
Total comments: 1
Dependent Patchsets: Messages
Total messages: 22 (9 generated)
The CQ bit was checked by dpranke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2094783003/1
ok, that took too long to cycle for me to want to commit it tonight, but hopefully we can land something early in the morning mtv time and see how things go.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2094783003/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2094783003/diff/1/tools/mb/mb_config.pyl#newc... tools/mb/mb_config.pyl:17: 'Mac': 'noswarming_gn_release_bot_mac_strip', I think we need to leave one waterfall on GYP until we actually ship the GN build. Should we keep the Mac Chromium one on GYP but only flip the official one?
On 2016/06/24 14:43:09, Robert Sesek wrote: > https://codereview.chromium.org/2094783003/diff/1/tools/mb/mb_config.pyl > File tools/mb/mb_config.pyl (right): > > https://codereview.chromium.org/2094783003/diff/1/tools/mb/mb_config.pyl#newc... > tools/mb/mb_config.pyl:17: 'Mac': 'noswarming_gn_release_bot_mac_strip', > I think we need to leave one waterfall on GYP until we actually ship the GN > build. Should we keep the Mac Chromium one on GYP but only flip the official > one? I agree with the theory. I'm actually going to flip one or two of the existing 'Mac GN' builders on the chromium.mac waterfall over to GYP (and/or rename them). Let's leave these on GN for now, though since they cover important use cases.
On 2016/06/24 15:46:54, Dirk Pranke wrote: > On 2016/06/24 14:43:09, Robert Sesek wrote: > > https://codereview.chromium.org/2094783003/diff/1/tools/mb/mb_config.pyl > > File tools/mb/mb_config.pyl (right): > > > > > https://codereview.chromium.org/2094783003/diff/1/tools/mb/mb_config.pyl#newc... > > tools/mb/mb_config.pyl:17: 'Mac': 'noswarming_gn_release_bot_mac_strip', > > I think we need to leave one waterfall on GYP until we actually ship the GN > > build. Should we keep the Mac Chromium one on GYP but only flip the official > > one? > > I agree with the theory. I'm actually going to flip one or two of the existing > 'Mac GN' > builders on the chromium.mac waterfall over to GYP (and/or rename them). Let's > leave these on GN for now, though since they cover important use cases. OK. Switching the GN builders to GYP sounds good. LGTM
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== Flip mac full builders to GN. This flips the 'Mac' build on the 'chromium' waterfall and the 'Google Chrome Mac' build on the 'chromium.chrome' waterfall to GN. If this sticks overnight, we can try to flip the official builders to GN in the morning. This also flips the 'mac_chromium_archive_rel_ng' MB config to match the 'Mac' config so that we can test builds more effectively. The official build still isn't "right", since we haven't ported over the installer for the remoting me2me host. I'm going to try and work around that for now so that we can see what else might be missing. R=rsesek@chromium.org, zijiehe@chromium.org BUG=618468 ========== to ========== Flip mac full builders to GN. This flips the 'Mac' build on the 'chromium' waterfall and the 'Google Chrome Mac' build on the 'chromium.chrome' waterfall to GN. If this sticks overnight, we can try to flip the official builders to GN in the morning. This also flips the 'mac_chromium_archive_rel_ng' MB config to match the 'Mac' config so that we can test builds more effectively. The official build still isn't "right", since we haven't ported over the installer for the remoting me2me host. I'm going to try and work around that for now so that we can see what else might be missing. R=rsesek@chromium.org TBR=zijiehe@chromium.org, sergeyu@chromium.org BUG=618468 ==========
dpranke@chromium.org changed reviewers: + sergeyu@chromium.org
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Flip mac full builders to GN. This flips the 'Mac' build on the 'chromium' waterfall and the 'Google Chrome Mac' build on the 'chromium.chrome' waterfall to GN. If this sticks overnight, we can try to flip the official builders to GN in the morning. This also flips the 'mac_chromium_archive_rel_ng' MB config to match the 'Mac' config so that we can test builds more effectively. The official build still isn't "right", since we haven't ported over the installer for the remoting me2me host. I'm going to try and work around that for now so that we can see what else might be missing. R=rsesek@chromium.org TBR=zijiehe@chromium.org, sergeyu@chromium.org BUG=618468 ========== to ========== Flip mac full builders to GN. This flips the 'Mac' build on the 'chromium' waterfall and the 'Google Chrome Mac' build on the 'chromium.chrome' waterfall to GN. If this sticks overnight, we can try to flip the official builders to GN in the morning. This also flips the 'mac_chromium_archive_rel_ng' MB config to match the 'Mac' config so that we can test builds more effectively. The official build still isn't "right", since we haven't ported over the installer for the remoting me2me host. I'm going to try and work around that for now so that we can see what else might be missing. R=rsesek@chromium.org TBR=zijiehe@chromium.org, sergeyu@chromium.org BUG=618468 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Flip mac full builders to GN. This flips the 'Mac' build on the 'chromium' waterfall and the 'Google Chrome Mac' build on the 'chromium.chrome' waterfall to GN. If this sticks overnight, we can try to flip the official builders to GN in the morning. This also flips the 'mac_chromium_archive_rel_ng' MB config to match the 'Mac' config so that we can test builds more effectively. The official build still isn't "right", since we haven't ported over the installer for the remoting me2me host. I'm going to try and work around that for now so that we can see what else might be missing. R=rsesek@chromium.org TBR=zijiehe@chromium.org, sergeyu@chromium.org BUG=618468 ========== to ========== Flip mac full builders to GN. This flips the 'Mac' build on the 'chromium' waterfall and the 'Google Chrome Mac' build on the 'chromium.chrome' waterfall to GN. If this sticks overnight, we can try to flip the official builders to GN in the morning. This also flips the 'mac_chromium_archive_rel_ng' MB config to match the 'Mac' config so that we can test builds more effectively. The official build still isn't "right", since we haven't ported over the installer for the remoting me2me host. I'm going to try and work around that for now so that we can see what else might be missing. R=rsesek@chromium.org TBR=zijiehe@chromium.org, sergeyu@chromium.org BUG=618468 Committed: https://crrev.com/63619254507db98dec507b02a4ac09a9a4629009 Cr-Commit-Position: refs/heads/master@{#401894} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/63619254507db98dec507b02a4ac09a9a4629009 Cr-Commit-Position: refs/heads/master@{#401894}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2091303004/ by prasadv@chromium.org. The reason for reverting is: Breaking Mac builders on chromium.perf and tryserver.chromium.perf.. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
