Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 2092173002: Flip mac and win "gn" builders back to GYP. (Closed)

Created:
4 years, 6 months ago by Dirk Pranke
Modified:
4 years, 6 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@flip_mac_full
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flip mac and win "gn" builders back to GYP. Now that the main builders are on GN, we can flip the dedicated "gn" builders back to GYP and rename them to "gyp" to avoid confusion and keep some GYP coverage on the main waterfalls (they will build "all" but not run tests or be in the CQ for now). R=rsesek@chromium.org BUG=618468, 605318 Committed: https://crrev.com/cf63a9a5e547087e23a0773e5875a1e2fa4331b1 Cr-Commit-Position: refs/heads/master@{#401910}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -16 lines) Patch
M testing/buildbot/chromium.mac.json View 1 chunk +12 lines, -2 lines 0 comments Download
M testing/buildbot/chromium.win.json View 1 chunk +12 lines, -2 lines 0 comments Download
M tools/mb/mb_config.pyl View 7 chunks +48 lines, -12 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (4 generated)
Dirk Pranke
4 years, 6 months ago (2016-06-24 17:00:56 UTC) #1
Dirk Pranke
I'll post a follow-on build-side CL to rename the builders and then another one to ...
4 years, 6 months ago (2016-06-24 17:01:27 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2092173002/1
4 years, 6 months ago (2016-06-24 17:02:29 UTC) #4
Robert Sesek
lgtm
4 years, 6 months ago (2016-06-24 17:04:40 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-24 18:03:31 UTC) #7
Dirk Pranke
I probably should've fed this through the affected trybots ...
4 years, 6 months ago (2016-06-24 18:06:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2092173002/1
4 years, 6 months ago (2016-06-24 18:07:21 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 18:12:39 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 18:14:10 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf63a9a5e547087e23a0773e5875a1e2fa4331b1
Cr-Commit-Position: refs/heads/master@{#401910}

Powered by Google App Engine
This is Rietveld 408576698