Issue 209473013: DevTools: Collect truncated scopes for async stacks.

Issue 209473013: DevTools: Collect truncated scopes for async stacks. (Closed)

Created:
6 years, 9 months ago by aandrey

Modified:
6 years, 9 months ago

Reviewers:
pfeldman, yurys

CC:
blink-reviews, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org, Nils Barth (inactive), caseq+blink_chromium.org, kojih, arv+blink, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, devtools-reviews_chromium.org, loislo+blink_chromium.org, sof, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, haraken, Nate Chapin, jsbell+bindings_chromium.org, alph+blink_chromium.org, kouhei+bindings_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: Collect truncated scopes for async stacks. For async stacks we will collect scopes up to the Local scope (i.e. no inner With or Catch scopes). This is way more faster (about 2x), since inner scopes require script parsing and scope analyzing. In the DevTools UI this is a small reduction, as any With object or exception can be evaluated on async call frame in the console while paused, or looked via a popup on mouseover. Speed gain: more than 2x. BUG=340285 R=yurys, pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169946

Patch Set 1 #

Total comments: 2

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -8 lines)			Patch
M	LayoutTests/inspector/sources/debugger/async-callstack-scopes.html	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/inspector/sources/debugger/async-callstack-scopes-expected.txt	View	3 chunks	+3 lines, -5 lines	0 comments	Download
M	Source/bindings/v8/DebuggerScript.js	View	1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

yurys

https://codereview.chromium.org/209473013/diff/1/Source/bindings/v8/DebuggerScript.js File Source/bindings/v8/DebuggerScript.js (right): https://codereview.chromium.org/209473013/diff/1/Source/bindings/v8/DebuggerScript.js#newcode338 Source/bindings/v8/DebuggerScript.js:338: var scopeMirrors = (scopeDetailsLevel === DebuggerScript.ScopeInfoDetails.NoScopes ? [] : ...

6 years, 9 months ago (2014-03-25 08:51:17 UTC) #2

aandrey

6 years, 9 months ago (2014-03-25 08:57:31 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/209473013/1

6 years, 9 months ago (2014-03-25 13:55:26 UTC) #6

Message was sent while issue was closed.

Change committed as 169946

Expand Messages | Collapse Messages