Source/bindings/v8/DebuggerScript.js - Issue 209473013: DevTools: Collect truncated scopes for async stacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/DebuggerScript.js

Issue 209473013: DevTools: Collect truncated scopes for async stacks. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/v8/DebuggerScript.js

diff --git a/Source/bindings/v8/DebuggerScript.js b/Source/bindings/v8/DebuggerScript.js

index 9d523e3133fd59e3c65da2bbb8cf9b17e8869061..38e48514b1f1ba9ed85bbc20f7407f97cd7fa869 100644

--- a/Source/bindings/v8/DebuggerScript.js

+++ b/Source/bindings/v8/DebuggerScript.js

@@ -335,7 +335,7 @@ DebuggerScript._frameMirrorToJSCallFrame = function(frameMirror, callerFrame, sc

var isAtReturn = !!frameDetails.isAtReturn();

var returnValue = isAtReturn ? frameDetails.returnValue() : undefined;

- var scopeMirrors = (scopeDetailsLevel === DebuggerScript.ScopeInfoDetails.NoScopes ? [] : frameMirror.allScopes());

+ var scopeMirrors = (scopeDetailsLevel === DebuggerScript.ScopeInfoDetails.NoScopes ? [] : frameMirror.allScopes(scopeDetailsLevel === DebuggerScript.ScopeInfoDetails.FastAsyncScopes));

yurys 2014/03/25 08:51:17 Is this parameter already supported in V8?

aandrey 2014/03/25 08:57:31 Surely. V8 change: https://codereview.chromium.org

var scopeTypes = new Array(scopeMirrors.length);

var scopeObjects = new Array(scopeMirrors.length);

for (var i = 0; i < scopeMirrors.length; ++i) {

« no previous file with comments | « LayoutTests/inspector/sources/debugger/async-callstack-scopes-expected.txt ('k') | no next file » | no next file with comments »