Chromium Code Reviews| Index: build/config/mac/mac_sdk.gni |
| diff --git a/build/config/mac/mac_sdk.gni b/build/config/mac/mac_sdk.gni |
| index 986bf7942a39342c7f8dbd3d88349b5f56fbe299..fc664e6e0bf49a45e1df7bb86fcb21ab32308ef4 100644 |
| --- a/build/config/mac/mac_sdk.gni |
| +++ b/build/config/mac/mac_sdk.gni |
| @@ -51,3 +51,27 @@ mac_sdk_build = _mac_sdk_result.sdk_build |
| xcode_version = _mac_sdk_result.xcode_version |
| xcode_build = _mac_sdk_result.xcode_build |
| machine_os_build = _mac_sdk_result.machine_os_build |
| + |
| +if (mac_sdk_version != mac_sdk_min_build_override && |
| + exec_script("//build/check_return_value.py", |
| + [ |
| + "test", |
| + xcode_version, |
| + "-ge", |
| + "0730", |
| + ], |
| + "value") != 1) { |
| + print( |
| + "********************************************************************************") |
| + print( |
| + " WARNING: The Mac OS X SDK is incompatible with the version of Xcode. To fix,") |
| + print( |
| + " either upgrade Xcode to the latest (7.3.1) or install the Mac OS X") |
|
Mark Mentovai
2016/06/25 20:31:38
Unless you plan on keeping the number 7.3.1 in syn
Robert Sesek
2016/06/29 20:43:34
Done.
|
| + print( |
| + " $mac_sdk_min_build_override SDK. For more information, see https://crbug.com/620127.") |
| + print() |
| + print(" Current SDK Version: $mac_sdk_version") |
| + print(" Current Xcode Version: $xcode_version ($xcode_build)") |
| + print( |
|
Mark Mentovai
2016/06/25 20:31:38
Does this go to stderr? (If not, could it?)
Robert Sesek
2016/06/29 20:43:34
It goes to stdout, as does the new assertion failu
|
| + "********************************************************************************") |
|
Mark Mentovai
2016/06/25 20:31:38
I like making this fatal, at least in the configur
Robert Sesek
2016/06/29 20:43:34
Done.
|
| +} |