Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 # Copyright 2014 The Chromium Authors. All rights reserved. | 1 # Copyright 2014 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 import("//build/config/chrome_build.gni") | 5 import("//build/config/chrome_build.gni") |
| 6 | 6 |
| 7 # See https://bugs.chromium.org/p/webrtc/issues/detail?id=5453. | 7 # See https://bugs.chromium.org/p/webrtc/issues/detail?id=5453. |
| 8 # We can drop the rtc_require_mac_10_7_deployment flag when Chromium | 8 # We can drop the rtc_require_mac_10_7_deployment flag when Chromium |
| 9 # also requires a 10.7 deployment target. | 9 # also requires a 10.7 deployment target. |
| 10 import("//build_overrides/build.gni") | 10 import("//build_overrides/build.gni") |
| (...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 44 if (mac_sdk_path == "") { | 44 if (mac_sdk_path == "") { |
| 45 mac_sdk_path = find_sdk_lines[0] | 45 mac_sdk_path = find_sdk_lines[0] |
| 46 } | 46 } |
| 47 | 47 |
| 48 script_name = "//build/config/mac/sdk_info.py" | 48 script_name = "//build/config/mac/sdk_info.py" |
| 49 _mac_sdk_result = exec_script(script_name, [ mac_sdk_name ], "scope") | 49 _mac_sdk_result = exec_script(script_name, [ mac_sdk_name ], "scope") |
| 50 mac_sdk_build = _mac_sdk_result.sdk_build | 50 mac_sdk_build = _mac_sdk_result.sdk_build |
| 51 xcode_version = _mac_sdk_result.xcode_version | 51 xcode_version = _mac_sdk_result.xcode_version |
| 52 xcode_build = _mac_sdk_result.xcode_build | 52 xcode_build = _mac_sdk_result.xcode_build |
| 53 machine_os_build = _mac_sdk_result.machine_os_build | 53 machine_os_build = _mac_sdk_result.machine_os_build |
| 54 | |
| 55 if (mac_sdk_version != mac_sdk_min_build_override && | |
| 56 exec_script("//build/check_return_value.py", | |
| 57 [ | |
| 58 "test", | |
| 59 xcode_version, | |
| 60 "-ge", | |
| 61 "0730", | |
| 62 ], | |
| 63 "value") != 1) { | |
| 64 print( | |
| 65 "************************************************************************* *******") | |
| 66 print( | |
| 67 " WARNING: The Mac OS X SDK is incompatible with the version of Xcode. To fix,") | |
| 68 print( | |
| 69 " either upgrade Xcode to the latest (7.3.1) or install the Mac O S X") | |
|
Mark Mentovai
2016/06/25 20:31:38
Unless you plan on keeping the number 7.3.1 in syn
Robert Sesek
2016/06/29 20:43:34
Done.
| |
| 70 print( | |
| 71 " $mac_sdk_min_build_override SDK. For more information, see http s://crbug.com/620127.") | |
| 72 print() | |
| 73 print(" Current SDK Version: $mac_sdk_version") | |
| 74 print(" Current Xcode Version: $xcode_version ($xcode_build)") | |
| 75 print( | |
|
Mark Mentovai
2016/06/25 20:31:38
Does this go to stderr? (If not, could it?)
Robert Sesek
2016/06/29 20:43:34
It goes to stdout, as does the new assertion failu
| |
| 76 "************************************************************************* *******") | |
|
Mark Mentovai
2016/06/25 20:31:38
I like making this fatal, at least in the configur
Robert Sesek
2016/06/29 20:43:34
Done.
| |
| 77 } | |
| OLD | NEW |