Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2094553003: [Merge to 2743] [Mac] Fix regression with copying URLs from the Omnibox. (Closed)

Created:
4 years, 6 months ago by erikchen
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

[Merge to 2743] [Mac] Fix regression with copying URLs from the Omnibox. > The function ClipboardUtil::PasteboardItemFromUrl was incorrectly attempting to > create a public UTI using UTIFromPboardType. The resulting NSPasteboardItem was > not correctly writing to the NSPasteboard. Using the public UTIs directly fixes > this problem. > > BUG=618771 > > Review-Url: https://codereview.chromium.org/2080603007 > Cr-Commit-Position: refs/heads/master@{#401134} (cherry picked from commit 23d52abd52313ed4431d33935d6a4d72394a350c) Committed: https://chromium.googlesource.com/chromium/src/+/2d84e10c2bbaa428299a7d654c9bf023ff1ca3a4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -14 lines) Patch
M ui/base/clipboard/clipboard_util_mac.mm View 3 chunks +6 lines, -14 lines 0 comments Download
M ui/base/clipboard/clipboard_util_mac_unittest.mm View 2 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
erikchen
4 years, 6 months ago (2016-06-23 16:19:03 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2d84e10c2bbaa428299a7d654c9bf023ff1ca3a4.

Powered by Google App Engine
This is Rietveld 408576698