Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2080603007: [Mac] Fix regression with copying URLs from the Omnibox. (Closed)

Created:
4 years, 6 months ago by erikchen
Modified:
4 years, 6 months ago
Reviewers:
shrike, ccameron
CC:
chromium-reviews, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Fix regression with copying URLs from the Omnibox. The function ClipboardUtil::PasteboardItemFromUrl was incorrectly attempting to create a public UTI using UTIFromPboardType. The resulting NSPasteboardItem was not correctly writing to the NSPasteboard. Using the public UTIs directly fixes this problem. BUG=618771 Committed: https://crrev.com/23d52abd52313ed4431d33935d6a4d72394a350c Cr-Commit-Position: refs/heads/master@{#401134}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -14 lines) Patch
M ui/base/clipboard/clipboard_util_mac.mm View 3 chunks +6 lines, -14 lines 0 comments Download
M ui/base/clipboard/clipboard_util_mac_unittest.mm View 2 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080603007/1
4 years, 6 months ago (2016-06-21 17:11:18 UTC) #2
erikchen
shrike, ccameron: PTAL Note that I don't have Outlook, so I wasn't able to test ...
4 years, 6 months ago (2016-06-21 17:11:26 UTC) #4
shrike
On 2016/06/21 17:11:26, erikchen wrote: > shrike, ccameron: PTAL > > Note that I don't ...
4 years, 6 months ago (2016-06-21 17:22:20 UTC) #5
erikchen
On 2016/06/21 17:22:20, shrike wrote: > On 2016/06/21 17:11:26, erikchen wrote: > > shrike, ccameron: ...
4 years, 6 months ago (2016-06-21 17:26:01 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-21 17:56:02 UTC) #8
shrike
ccameron@ - do you have a spare moment to review this cl? We're trying to ...
4 years, 6 months ago (2016-06-21 22:19:03 UTC) #9
ccameron
rs lgtm
4 years, 6 months ago (2016-06-21 22:23:52 UTC) #10
shrike
On 2016/06/21 17:26:01, erikchen wrote: > Which version of macOS? copy-pasting from the omnibox into ...
4 years, 6 months ago (2016-06-21 22:27:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080603007/1
4 years, 6 months ago (2016-06-21 22:40:00 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 22:51:41 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 22:53:20 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/23d52abd52313ed4431d33935d6a4d72394a350c
Cr-Commit-Position: refs/heads/master@{#401134}

Powered by Google App Engine
This is Rietveld 408576698