chrome/browser/chromeos/BUILD.gn - Issue 2094333002: Implementation for chrome.certificateProvider.requestPin/stopPinRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/BUILD.gn

Issue 2094333002: Implementation for chrome.certificateProvider.requestPin/stopPinRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed review comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/chromeos_strings.grdp ('K') | « chrome/app/chromeos_strings.grdp ('k') | chrome/browser/chromeos/certificate_provider/certificate_provider_service.h » ('j') | chrome/browser/extensions/api/certificate_provider/certificate_provider_api.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/BUILD.gn

diff --git a/chrome/browser/chromeos/BUILD.gn b/chrome/browser/chromeos/BUILD.gn

index 0fa9880221e8b07fae4f2b553b8d47caf2f935d7..a5954c468b959a28fc9c8dd68ef06bada0194662 100644

--- a/chrome/browser/chromeos/BUILD.gn

+++ b/chrome/browser/chromeos/BUILD.gn

@@ -279,6 +279,8 @@ source_set("chromeos") {

"certificate_provider/certificate_provider_service_factory.h",

"certificate_provider/certificate_requests.cc",

"certificate_provider/certificate_requests.h",

+ "certificate_provider/pin_dialog_manager.cc",

+ "certificate_provider/pin_dialog_manager.h",

"certificate_provider/sign_requests.cc",

"certificate_provider/sign_requests.h",

"certificate_provider/thread_safe_certificate_map.cc",

@@ -1238,6 +1240,8 @@ source_set("chromeos") {

"ui/low_disk_notification.h",

"ui/mobile_config_ui.cc",

"ui/mobile_config_ui.h",

+ "ui/request_pin_view.cc",

+ "ui/request_pin_view.h",

"ui/screen_capture_notification_ui_chromeos.cc",

"ui/screen_capture_notification_ui_chromeos.h",

"ui_proxy_config.cc",