Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1553)

Unified Diff: chrome/app/chromeos_strings.grdp

Issue 2094333002: Implementation for chrome.certificateProvider.requestPin/stopPinRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed review comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/app/chromeos_strings.grdp
diff --git a/chrome/app/chromeos_strings.grdp b/chrome/app/chromeos_strings.grdp
index 5499606da3210f4775b0293aafcdf0b9d0abb068..8acb2818df1551d05fa6296f8e9901407c8722f9 100644
--- a/chrome/app/chromeos_strings.grdp
+++ b/chrome/app/chromeos_strings.grdp
@@ -6461,7 +6461,7 @@ All users must sign out to continue.
</message>
<message name="IDS_FLAGS_ENABLE_IME_MENU_NAME" desc="Name of the about: flag for enabling opt-in IME menu.">
Enable opt-in IME menu
- </message>
+ </message>
<message name="IDS_FLAGS_ENABLE_IME_MENU_DESCRIPTION" desc="Description of the about: flag for enabling opt-in IME menu.">
Enable access to the new IME menu in the Language Settings page.
</message>
@@ -6489,4 +6489,32 @@ All users must sign out to continue.
<message name="IDS_HATS_DONE_BUTTON_LABEL" desc="Label used for the done button at the end of survey">
Done
</message>
+ <message name="IDS_REQUEST_PIN_DIALOG_HEADER" desc="The text displayed certificate provider PIN request dialog.">
Devlin 2016/11/01 16:24:30 The text displayed *in* the certificate....?
igorcov 2016/11/04 15:51:42 Done.
+ "<ph name="EXTENSION_NAME">$1<ex>My Extension</ex></ph>" is requesting your <ph name="CODE_TYPE">$2<ex>PIN</ex></ph>
+ </message>
+ <message name="IDS_REQUEST_PIN_DIALOG_PROCESSING" desc="The text displayed while the certificate provider API is waiting for notification request from extension.">
Devlin 2016/11/01 16:24:30 what is a notification request? Wouldn't this be
igorcov 2016/11/04 15:51:42 Done.
+ Processing request...
+ </message>
+ <message name="IDS_REQUEST_PIN_DIALOG_INVALID_PIN_ERROR" desc="The error message displayed in certificate provider PIN request dialog when invalid PIN was entered.">
Devlin 2016/11/01 16:24:30 in *the* certificate provider...? when *an* invali
+ Invalid PIN.
+ </message>
+ <message name="IDS_REQUEST_PIN_DIALOG_INVALID_PUK_ERROR" desc="The error message displayed in certificate provider PIN request dialog when invalid PUK was entered.">
Devlin 2016/11/01 16:24:30 in *the* certificate when *an* invalid
igorcov 2016/11/04 15:51:42 Done.
+ Invalid PUK.
+ </message>
+ <message name="IDS_REQUEST_PIN_DIALOG_MAX_ATTEMPTS_EXCEEDED_ERROR" desc="The error message displayed in certificate provider PIN request dialog when maximum allowed attempts exceeded.">
Devlin 2016/11/01 16:24:30 ditto
igorcov 2016/11/04 15:51:42 Done.
+ Maximum allowed attempts exceeded.
+ </message>
+ <message name="IDS_REQUEST_PIN_DIALOG_UNKNOWN_ERROR" desc="The error message displayed in certificate provider PIN request dialog when unknown error occurred in extension code.">
+ Unknown error.
+ </message>
+ <message name="IDS_REQUEST_PIN_DIALOG_ATTEMPTS_LEFT" desc="The text displayed in certificate provider PIN request dialog about the number of attempts left">
+ Attempts left: $1
+ </message>
+ <message name="IDS_REQUEST_PIN_DIALOG_PIN" desc="The Provider Identification Number abbreviation">
+ PIN
+ </message>
+ <message name="IDS_REQUEST_PIN_DIALOG_PUK" desc="The Personal Unlocking Key (as used in mobile phones) abbreviation">
+ PUK
+ </message>
+
</grit-part>

Powered by Google App Engine
This is Rietveld 408576698