Implementation for chrome.certificateProvider.requestPin/stopPinRequest

chrome/browser/chromeos/certificate_provider/certificate_provider_service.h

Index: chrome/browser/chromeos/certificate_provider/certificate_provider_service.h
diff --git a/chrome/browser/chromeos/certificate_provider/certificate_provider_service.h b/chrome/browser/chromeos/certificate_provider/certificate_provider_service.h
index dada1f2250e74172a72f935196dadba9d9a347ee..b95717c43650c1ccd6f48bd0fa3dbc23fd83e805 100644
--- a/chrome/browser/chromeos/certificate_provider/certificate_provider_service.h
+++ b/chrome/browser/chromeos/certificate_provider/certificate_provider_service.h
@@ -19,6 +19,7 @@
 #include "base/threading/thread_checker.h"
 #include "chrome/browser/chromeos/certificate_provider/certificate_info.h"
 #include "chrome/browser/chromeos/certificate_provider/certificate_requests.h"
+#include "chrome/browser/chromeos/certificate_provider/pin_dialog_manager.h"
 #include "chrome/browser/chromeos/certificate_provider/sign_requests.h"
 #include "chrome/browser/chromeos/certificate_provider/thread_safe_certificate_map.h"
 #include "components/keyed_service/core/keyed_service.h"
@@ -150,6 +151,8 @@ class CertificateProviderService : public KeyedService {
   // corresponding notification of the ExtensionRegistry is triggered.
   void OnExtensionUnloaded(const std::string& extension_id);
 
+  PinDialogManager* pin_dialog_manager() { return pin_dialog_manager_.get(); }
+
  private:
   class CertKeyProviderImpl;
   class CertificateProviderImpl;
@@ -191,6 +194,10 @@ class CertificateProviderService : public KeyedService {
   // the net::ClientKeyStore singleton.
   std::unique_ptr<CertKeyProviderImpl> cert_key_provider_;
 
+  // The object to manage the dialog displayed when requestPin is called by the
+  // extension.
+  std::unique_ptr<PinDialogManager> pin_dialog_manager_;

[Devlin, 2016/10/20 21:20:43]

This seems to never be null, nor destroyed.  Why not just own the object
directly?

[igorcov, 2016/10/25 16:38:35]

Done.

+
   // State about all pending sign requests.
   certificate_provider::SignRequests sign_requests_;