Implementation for chrome.certificateProvider.requestPin/stopPinRequest

chrome/browser/chromeos/certificate_provider/certificate_provider_service.cc

Index: chrome/browser/chromeos/certificate_provider/certificate_provider_service.cc
diff --git a/chrome/browser/chromeos/certificate_provider/certificate_provider_service.cc b/chrome/browser/chromeos/certificate_provider/certificate_provider_service.cc
index 806cac9ff47c7bb564825d91961e027eb992b056..9ffb2d763cd0be919ed1a949bbe457140e520349 100644
--- a/chrome/browser/chromeos/certificate_provider/certificate_provider_service.cc
+++ b/chrome/browser/chromeos/certificate_provider/certificate_provider_service.cc
@@ -296,8 +296,9 @@ void CertificateProviderService::SSLPrivateKey::DidSignDigest(
   callback.Run(error, signature);
 }
 
-CertificateProviderService::CertificateProviderService()
-    : weak_factory_(this) {}
+CertificateProviderService::CertificateProviderService() : weak_factory_(this) {

[Devlin, 2016/10/20 21:20:43]

why not initialize this in the initializer list?

[igorcov, 2016/10/25 16:38:35]

Done.

+  pin_dialog_manager_.reset(new PinDialogManager());
+}
 
 CertificateProviderService::~CertificateProviderService() {
   DCHECK(thread_checker_.CalledOnValidThread());
@@ -400,6 +401,8 @@ void CertificateProviderService::OnExtensionUnloaded(
 
   for (auto callback : sign_requests_.RemoveAllRequests(extension_id))
     callback.Run(net::ERR_FAILED, std::vector<uint8_t>());
+
+  pin_dialog_manager_->ExtensionUnloaded(extension_id);
 }
 
 void CertificateProviderService::GetCertificatesFromExtensions(