Implementation for chrome.certificateProvider.requestPin/stopPinRequest

chrome/browser/chromeos/certificate_provider/pin_dialog_manager.h

Index: chrome/browser/chromeos/certificate_provider/pin_dialog_manager.h
diff --git a/chrome/browser/chromeos/certificate_provider/pin_dialog_manager.h b/chrome/browser/chromeos/certificate_provider/pin_dialog_manager.h
new file mode 100644
index 0000000000000000000000000000000000000000..2d31ed4be5d61d47640142a4406588dac6430d76
--- /dev/null
+++ b/chrome/browser/chromeos/certificate_provider/pin_dialog_manager.h
@@ -0,0 +1,118 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_CHROMEOS_CERTIFICATE_PROVIDER_PIN_DIALOG_MANAGER_H_
+#define CHROME_BROWSER_CHROMEOS_CERTIFICATE_PROVIDER_PIN_DIALOG_MANAGER_H_
+
+#include <map>
+#include <string>
+#include <unordered_map>
+
+#include "base/callback.h"
+#include "base/memory/weak_ptr.h"
+#include "base/strings/string16.h"
+#include "chrome/browser/chromeos/ui/request_pin_view.h"
+#include "ui/views/widget/widget.h"
+
+namespace chromeos {
+
+// Manages the state of the dialog that requests the PIN from user. Used by the
+// extensions that need to request the PIN. Implemented as requirement for
+// crbug.com/612886
+class PinDialogManager : RequestPinView::Delegate {
+ public:
+  typedef std::pair<std::string, int> ExtensionNameRequestIdPair;

[emaxx, 2016/09/19 14:01:43]

nit: Move this type definition into the private section: it's not used by any of
the public definitions.

[emaxx, 2016/09/19 14:01:43]

nit: #include <utility>

[igorcov, 2016/09/19 18:19:20]

Done.

[igorcov, 2016/09/19 18:19:20]

Done.

+
+  enum RequestPinResponse {
+    SUCCESS,
+    INVALID_ID,
+    OTHER_FLOW_IN_PROGRESS,
+    DIALOG_DISPLAYED_ALREADY
+  };
+
+  PinDialogManager();
+  ~PinDialogManager();
+
+  // Stores internally the |signRequestId| along with current timestamp. Also
+  // cleans up the storage from expired IDs. In unlikely case that the ID
+  // exists in the storage, returns false. Otherwise returns true.
+  bool AddSignRequestId(const std::string& extension_id, int sign_request_id);
+
+  // Creates a new RequestPinView object and displays it in a dialog or reuses
+  // the old dialog if active one exists just updating the parameters.
+  // |extension_id| - the ID of the extension requesting the dialog.
+  // |extension_name| - the name of the extension requesting the dialog.
+  // |sign_request_id| - the ID given by Chrome when the extension was asked to
+  //     sign the data. It should be a valid, not expired ID at the time the
+  //     extension is requesting PIN the first time.
+  // |code_type| - the type of input requested: either "PIN" or "PUK".
+  // |error_type| - the error template to be displayed inside the dialog. If
+  //     NONE, no error is displayed.
+  // |attempts_left| - the number of attempts the user has to try the code. It
+  //     is informational only, and enforced on Chrome side only in case it's
+  //     zero. In that case the textfield is disabled and the user can't provide
+  //     any input to extension. If -1 the textfield from the dialog is enabled
+  //     but no information about the attepts left is not given to the user.
+  // |callback| - used to notify about the user input in the text_field from the
+  //     dialog.
+  // Returns SUCCESS if the dialog is displayed and extension owns it. Otherwise
+  // the specific error is returned.
+  RequestPinResponse ShowPinDialog(
+      const std::string& extension_id,
+      const std::string& extension_name,
+      int sign_request_id,
+      RequestPinView::RequestPinCodeType code_type,
+      RequestPinView::RequestPinErrorType error_type,
+      int attempts_left,
+      const RequestPinView::RequestPinCallback& callback);
+
+  // The user provided input to dialog.
+  void OnPinDialogInput();
+
+  // chromeos::CloseViewDelegate
+  void OnPinDialogClosed() override;
+
+  // Updates the existing dialog with new error message. Uses |callback| with
+  // empty string when user closes the dialog. Returns whether the provided
+  // |extension_id| matches the extension owning the active dialog.
+  bool UpdatePinDialog(const std::string& extension_id,
+                       RequestPinView::RequestPinErrorType error_type,
+                       bool accept_input,
+                       const RequestPinView::RequestPinCallback& callback);
+
+  // Returns whether the last PIN dialog from this extension was closed by the
+  // user.
+  bool LastPinDialogClosed(const std::string& extension_id);

[emaxx, 2016/09/19 14:01:43]

nit: Make the method const.

[igorcov, 2016/09/19 18:19:20]

Done.

+
+  // Called when extension calls the stopPinRequest method. The active dialog is
+  // closed if the |extension_id| matches the |active_dialog_extension_id_|.
+  // Returns whether the dialog was closed.
+  bool CloseDialog(const std::string& extension_id);
+
+  // Resets the manager data related to the extension.
+  void ExtensionUnloaded(const std::string& extension_id);
+
+  RequestPinView* active_view_for_testing() { return active_pin_dialog_; }
+  views::Widget* active_window_for_testing() { return active_window_; }
+
+ private:
+  // State about the last response from user to the requestPin from extension.

[emaxx, 2016/09/19 14:01:43]

nit: Please use more specific words here than just "state about the last
response".

[igorcov, 2016/09/19 18:19:19]

Done.

+  std::unordered_map<std::string, bool> last_response_closed_;
+
+  // The map with extension_id and sign request id issued by Chrome as key while
+  // the time when the id was generated is the value.
+  std::map<ExtensionNameRequestIdPair, base::Time> sign_request_times_;

[emaxx, 2016/09/19 14:01:43]

nit: #include "base/time/time.h"

+
+  // There can be only one active dialog to request PIN from this extension.

[emaxx, 2016/09/19 14:01:43]

nit: The current comment may be understood as there's only one dialog allowed
_per extension_, which isn't true.
Please edit the text to be more precise.

[igorcov, 2016/09/19 18:19:20]

Done.

+  // Owned by |active_window_|.
+  chromeos::RequestPinView* active_pin_dialog_ = nullptr;

[emaxx, 2016/09/19 14:01:43]

nit: "chromeos::" is not required here.

[igorcov, 2016/09/19 18:19:20]

Done.

+  std::string active_dialog_extension_id_;
+  views::Widget* active_window_ = nullptr;
+
+  base::WeakPtrFactory<PinDialogManager> weak_factory_;
+};
+
+}  // namespace chromeos
+
+#endif  // CHROME_BROWSER_CHROMEOS_CERTIFICATE_PROVIDER_PIN_DIALOG_MANAGER_H_