chrome/browser/chromeos/certificate_provider/certificate_provider_service_factory.cc - Issue 2094333002: Implementation for chrome.certificateProvider.requestPin/stopPinRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/certificate_provider/certificate_provider_service_factory.cc

Issue 2094333002: Implementation for chrome.certificateProvider.requestPin/stopPinRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed review comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/certificate_provider/certificate_provider_service.h ('K') | « chrome/browser/chromeos/certificate_provider/certificate_provider_service.cc ('k') | chrome/browser/chromeos/certificate_provider/pin_dialog_manager.h » ('j') | chrome/browser/chromeos/certificate_provider/pin_dialog_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/certificate_provider/certificate_provider_service_factory.cc

diff --git a/chrome/browser/chromeos/certificate_provider/certificate_provider_service_factory.cc b/chrome/browser/chromeos/certificate_provider/certificate_provider_service_factory.cc

index eec8b3bf2483b30e2f303a1158e9857ef021862d..86e6764bb3da705786cbacd14d6ca04e1c37f97c 100644

--- a/chrome/browser/chromeos/certificate_provider/certificate_provider_service_factory.cc

+++ b/chrome/browser/chromeos/certificate_provider/certificate_provider_service_factory.cc

@@ -14,6 +14,7 @@

#include "base/memory/ptr_util.h"

#include "base/memory/ref_counted.h"

#include "base/memory/singleton.h"

+#include "base/rand_util.h"

#include "base/values.h"

#include "chrome/browser/chromeos/certificate_provider/certificate_provider_service.h"

#include "chrome/browser/profiles/incognito_helpers.h"

@@ -112,6 +113,8 @@ bool DefaultDelegate::DispatchSignRequestToExtension(

return false;

api_cp::SignRequest request;

+ service_->pin_dialog_manager()->AddSignRequestId(extension_id, request_id);

+ request.sign_request_id = request_id;

switch (hash) {

case net::SSLPrivateKey::Hash::MD5_SHA1:

request.hash = api_cp::HASH_MD5_SHA1;