Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1547)

Unified Diff: chrome/browser/chromeos/certificate_provider/certificate_provider_service.cc

Issue 2094333002: Implementation for chrome.certificateProvider.requestPin/stopPinRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed review comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/certificate_provider/certificate_provider_service.cc
diff --git a/chrome/browser/chromeos/certificate_provider/certificate_provider_service.cc b/chrome/browser/chromeos/certificate_provider/certificate_provider_service.cc
index 88bd84133790e9cb7c15e4e77ee93b2361155316..0dfae9bc44b527e85b032d4abc49671aad3528bf 100644
--- a/chrome/browser/chromeos/certificate_provider/certificate_provider_service.cc
+++ b/chrome/browser/chromeos/certificate_provider/certificate_provider_service.cc
@@ -296,8 +296,9 @@ void CertificateProviderService::SSLPrivateKey::DidSignDigest(
callback.Run(error, signature);
}
-CertificateProviderService::CertificateProviderService()
- : weak_factory_(this) {}
+CertificateProviderService::CertificateProviderService() : weak_factory_(this) {
+ pin_dialog_manager_.reset(new PinDialogManager());
+}
CertificateProviderService::~CertificateProviderService() {
DCHECK(thread_checker_.CalledOnValidThread());
@@ -400,6 +401,8 @@ void CertificateProviderService::OnExtensionUnloaded(
for (auto callback : sign_requests_.RemoveAllRequests(extension_id))
callback.Run(net::ERR_FAILED, std::vector<uint8_t>());
+
+ pin_dialog_manager_->ExtensionUnloaded(extension_id);
}
void CertificateProviderService::GetCertificatesFromExtensions(

Powered by Google App Engine
This is Rietveld 408576698