Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3977)

Unified Diff: chrome/browser/chromeos/certificate_provider/certificate_provider_service.h

Issue 2094333002: Implementation for chrome.certificateProvider.requestPin/stopPinRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed review comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/certificate_provider/certificate_provider_service.h
diff --git a/chrome/browser/chromeos/certificate_provider/certificate_provider_service.h b/chrome/browser/chromeos/certificate_provider/certificate_provider_service.h
index dada1f2250e74172a72f935196dadba9d9a347ee..b95717c43650c1ccd6f48bd0fa3dbc23fd83e805 100644
--- a/chrome/browser/chromeos/certificate_provider/certificate_provider_service.h
+++ b/chrome/browser/chromeos/certificate_provider/certificate_provider_service.h
@@ -19,6 +19,7 @@
#include "base/threading/thread_checker.h"
#include "chrome/browser/chromeos/certificate_provider/certificate_info.h"
#include "chrome/browser/chromeos/certificate_provider/certificate_requests.h"
+#include "chrome/browser/chromeos/certificate_provider/pin_dialog_manager.h"
stevenjb 2016/09/12 21:16:39 You can forward declare PinDialogManager in this h
igorcov 2016/09/13 14:19:32 It doesn't compile because there also a getter imp
#include "chrome/browser/chromeos/certificate_provider/sign_requests.h"
#include "chrome/browser/chromeos/certificate_provider/thread_safe_certificate_map.h"
#include "components/keyed_service/core/keyed_service.h"
@@ -150,6 +151,8 @@ class CertificateProviderService : public KeyedService {
// corresponding notification of the ExtensionRegistry is triggered.
void OnExtensionUnloaded(const std::string& extension_id);
+ PinDialogManager* pin_dialog_manager() { return pin_dialog_manager_.get(); }
+
private:
class CertKeyProviderImpl;
class CertificateProviderImpl;
@@ -191,6 +194,10 @@ class CertificateProviderService : public KeyedService {
// the net::ClientKeyStore singleton.
std::unique_ptr<CertKeyProviderImpl> cert_key_provider_;
+ // The object to manage the dialog displayed when requestPin is called by the
+ // extension.
+ std::unique_ptr<PinDialogManager> pin_dialog_manager_;
+
// State about all pending sign requests.
certificate_provider::SignRequests sign_requests_;

Powered by Google App Engine
This is Rietveld 408576698