Issue 209433006: Add SkASSERT's to gl/Interface validate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 209433006: Add SkASSERT's to gl/Interface validate (Closed)

Created:
6 years, 9 months ago by egdaniel

Modified:
6 years, 9 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Add SkASSERT's to gl/Interface validate BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13920

Patch Set 2 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -29 lines)			Patch
	M	src/gpu/gl/GrGLInterface.cpp	View	1	18 chunks	+33 lines, -29 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

bsalomon

https://codereview.chromium.org/209433006/diff/1/src/gpu/gl/GrGLInterface.cpp File src/gpu/gl/GrGLInterface.cpp (right): https://codereview.chromium.org/209433006/diff/1/src/gpu/gl/GrGLInterface.cpp#newcode15 src/gpu/gl/GrGLInterface.cpp:15: #define RETURN_FALSE_INTERFACE \ lgtm, but can you move this ...

6 years, 9 months ago (2014-03-24 17:46:35 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/egdaniel@google.com/209433006/20001

6 years, 9 months ago (2014-03-24 18:10:49 UTC) #4

Message was sent while issue was closed.

Change committed as 13920

Expand Messages | Collapse Messages

Issue 209433006: Add SkASSERT's to gl/Interface validate (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages