Add SkASSERT's to gl/Interface validate

src/gpu/gl/GrGLInterface.cpp

 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 #include "gl/GrGLInterface.h"
 #include "gl/GrGLExtensions.h"
@@ skipping 98 matching lines @@
     clone->fStandard = interface->fStandard;
     clone->fExtensions = interface->fExtensions;
     clone->fFunctions = interface->fFunctions;
 #if GR_GL_PER_GL_FUNC_CALLBACK
     clone->fCallback = interface->fCallback;
     clone->fCallbackData = interface->fCallbackData;
 #endif
     return clone;
 }
 
+#define RETURN_FALSE_INTERFACE                             \
+    GrDebugCrash("GrGLInterface::validate() failed.");     \
+    return false;                                          \
+
 bool GrGLInterface::validate() const {
 
     if (kNone_GrGLStandard == fStandard) {
-        return false;
+        RETURN_FALSE_INTERFACE
     }
 
     if (!fExtensions.isInitialized()) {
-        return false;
+        RETURN_FALSE_INTERFACE
     }
 
     // functions that are always required
     if (NULL == fFunctions.fActiveTexture ||
         NULL == fFunctions.fAttachShader ||
         NULL == fFunctions.fBindAttribLocation ||
         NULL == fFunctions.fBindBuffer ||
         NULL == fFunctions.fBindTexture ||
         NULL == fFunctions.fBlendFunc ||
         NULL == fFunctions.fBlendColor ||      // -> GL >= 1.4, ES >= 2.0 or extension
@@ skipping 75 matching lines @@
         NULL == fFunctions.fDeleteRenderbuffers ||
         NULL == fFunctions.fFinish ||
         NULL == fFunctions.fFlush ||
         NULL == fFunctions.fFramebufferRenderbuffer ||
         NULL == fFunctions.fFramebufferTexture2D ||
         NULL == fFunctions.fGetFramebufferAttachmentParameteriv ||
         NULL == fFunctions.fGetRenderbufferParameteriv ||
         NULL == fFunctions.fGenFramebuffers ||
         NULL == fFunctions.fGenRenderbuffers ||
         NULL == fFunctions.fRenderbufferStorage) {
-        return false;
+        RETURN_FALSE_INTERFACE
     }
 
     GrGLVersion glVer = GrGLGetVersion(this);
 
     bool isCoreProfile = false;
     if (kGL_GrGLStandard == fStandard && glVer >= GR_GL_VER(3,2)) {
         GrGLint profileMask;
         GR_GL_GetIntegerv(this, GR_GL_CONTEXT_PROFILE_MASK, &profileMask);
         isCoreProfile = SkToBool(profileMask & GR_GL_CONTEXT_CORE_PROFILE_BIT);
     }
 
     // Now check that baseline ES/Desktop fns not covered above are present
     // and that we have fn pointers for any advertised fExtensions that we will
     // try to use.
 
     // these functions are part of ES2, we assume they are available
     // On the desktop we assume they are available if the extension
     // is present or GL version is high enough.
     if (kGLES_GrGLStandard == fStandard) {
         if (NULL == fFunctions.fStencilFuncSeparate ||
             NULL == fFunctions.fStencilMaskSeparate ||
             NULL == fFunctions.fStencilOpSeparate) {
-            return false;
+            RETURN_FALSE_INTERFACE
         }
     } else if (kGL_GrGLStandard == fStandard) {
 
         if (glVer >= GR_GL_VER(2,0)) {
             if (NULL == fFunctions.fStencilFuncSeparate ||
                 NULL == fFunctions.fStencilMaskSeparate ||
                 NULL == fFunctions.fStencilOpSeparate) {
-                return false;
+                RETURN_FALSE_INTERFACE
             }
         }
         if (glVer >= GR_GL_VER(3,0) && NULL == fFunctions.fBindFragDataLocation) {
-            return false;
+            RETURN_FALSE_INTERFACE
         }
         if (glVer >= GR_GL_VER(2,0) || fExtensions.has("GL_ARB_draw_buffers")) {
             if (NULL == fFunctions.fDrawBuffers) {
-                return false;
+                RETURN_FALSE_INTERFACE
             }
         }
 
         if (glVer >= GR_GL_VER(1,5) || fExtensions.has("GL_ARB_occlusion_query")) {
             if (NULL == fFunctions.fGenQueries ||
                 NULL == fFunctions.fDeleteQueries ||
                 NULL == fFunctions.fBeginQuery ||
                 NULL == fFunctions.fEndQuery ||
                 NULL == fFunctions.fGetQueryiv ||
                 NULL == fFunctions.fGetQueryObjectiv ||
                 NULL == fFunctions.fGetQueryObjectuiv) {
-                return false;
+                RETURN_FALSE_INTERFACE
             }
         }
         if (glVer >= GR_GL_VER(3,3) ||
             fExtensions.has("GL_ARB_timer_query") ||
             fExtensions.has("GL_EXT_timer_query")) {
             if (NULL == fFunctions.fGetQueryObjecti64v ||
                 NULL == fFunctions.fGetQueryObjectui64v) {
-                return false;
+                RETURN_FALSE_INTERFACE
             }
         }
         if (glVer >= GR_GL_VER(3,3) || fExtensions.has("GL_ARB_timer_query")) {
             if (NULL == fFunctions.fQueryCounter) {
-                return false;
+                RETURN_FALSE_INTERFACE
             }
         }
         if (!isCoreProfile) {
             if (NULL == fFunctions.fLoadIdentity ||
                 NULL == fFunctions.fLoadMatrixf ||
                 NULL == fFunctions.fMatrixMode ||
                 NULL == fFunctions.fTexGenfv ||
                 NULL == fFunctions.fTexGeni) {
-                return false;
+                RETURN_FALSE_INTERFACE
             }
         }
         if (fExtensions.has("GL_NV_path_rendering")) {
             if (NULL == fFunctions.fPathCommands ||
                 NULL == fFunctions.fPathCoords ||
                 NULL == fFunctions.fPathSubCommands ||
                 NULL == fFunctions.fPathSubCoords ||
                 NULL == fFunctions.fPathString ||
                 NULL == fFunctions.fPathGlyphs ||
                 NULL == fFunctions.fPathGlyphRange ||
@@ skipping 32 matching lines @@
                 NULL == fFunctions.fGetPathMetricRange ||
                 NULL == fFunctions.fGetPathSpacing ||
                 NULL == fFunctions.fGetPathColorGeniv ||
                 NULL == fFunctions.fGetPathColorGenfv ||
                 NULL == fFunctions.fGetPathTexGeniv ||
                 NULL == fFunctions.fGetPathTexGenfv ||
                 NULL == fFunctions.fIsPointInFillPath ||
                 NULL == fFunctions.fIsPointInStrokePath ||
                 NULL == fFunctions.fGetPathLength ||
                 NULL == fFunctions.fPointAlongPath) {
-                return false;
+                RETURN_FALSE_INTERFACE
             }
         }
     }
 
     // optional function on desktop before 1.3
     if (kGL_GrGLStandard != fStandard ||
         (glVer >= GR_GL_VER(1,3)) ||
         fExtensions.has("GL_ARB_texture_compression")) {
         if (NULL == fFunctions.fCompressedTexImage2D) {
-            return false;
+            RETURN_FALSE_INTERFACE
         }
     }
 
     // part of desktop GL, but not ES
     if (kGL_GrGLStandard == fStandard &&
         (NULL == fFunctions.fGetTexLevelParameteriv ||
          NULL == fFunctions.fDrawBuffer ||
          NULL == fFunctions.fReadBuffer)) {
-        return false;
+        RETURN_FALSE_INTERFACE
     }
 
     // GL_EXT_texture_storage is part of desktop 4.2
     // There is a desktop ARB extension and an ES+desktop EXT extension
     if (kGL_GrGLStandard == fStandard) {
         if (glVer >= GR_GL_VER(4,2) ||
             fExtensions.has("GL_ARB_texture_storage") ||
             fExtensions.has("GL_EXT_texture_storage")) {
             if (NULL == fFunctions.fTexStorage2D) {
-                return false;
+                RETURN_FALSE_INTERFACE
             }
         }
     } else if (glVer >= GR_GL_VER(3,0) || fExtensions.has("GL_EXT_texture_storage")) {
         if (NULL == fFunctions.fTexStorage2D) {
-            return false;
+            RETURN_FALSE_INTERFACE
         }
     }
 
     if (fExtensions.has("GL_EXT_discard_framebuffer")) {
 // FIXME: Remove this once Chromium is updated to provide this function
 #if 0
         if (NULL == fFunctions.fDiscardFramebuffer) {
-            return false;
+            RETURN_FALSE_INTERFACE
         }
 #endif
     }
 
     // FBO MSAA
     if (kGL_GrGLStandard == fStandard) {
         // GL 3.0 and the ARB extension have multisample + blit
         if (glVer >= GR_GL_VER(3,0) || fExtensions.has("GL_ARB_framebuffer_object")) {
             if (NULL == fFunctions.fRenderbufferStorageMultisample ||
                 NULL == fFunctions.fBlitFramebuffer) {
-                return false;
+                RETURN_FALSE_INTERFACE
             }
         } else {
             if (fExtensions.has("GL_EXT_framebuffer_blit") &&
                 NULL == fFunctions.fBlitFramebuffer) {
-                return false;
+                RETURN_FALSE_INTERFACE
             }
             if (fExtensions.has("GL_EXT_framebuffer_multisample") &&
                 NULL == fFunctions.fRenderbufferStorageMultisample) {
-                return false;
+                RETURN_FALSE_INTERFACE
             }
         }
     } else {
         if (glVer >= GR_GL_VER(3,0) || fExtensions.has("GL_CHROMIUM_framebuffer_multisample")) {
             if (NULL == fFunctions.fRenderbufferStorageMultisample ||
                 NULL == fFunctions.fBlitFramebuffer) {
-                return false;
+                RETURN_FALSE_INTERFACE
             }
         }
         if (fExtensions.has("GL_APPLE_framebuffer_multisample")) {
             if (NULL == fFunctions.fRenderbufferStorageMultisampleES2APPLE ||
                 NULL == fFunctions.fResolveMultisampleFramebuffer) {
-                return false;
+                RETURN_FALSE_INTERFACE
             }
         }
         if (fExtensions.has("GL_IMG_multisampled_render_to_texture") ||
             fExtensions.has("GL_EXT_multisampled_render_to_texture")) {
             if (NULL == fFunctions.fRenderbufferStorageMultisampleES2EXT ||
                 NULL == fFunctions.fFramebufferTexture2DMultisample) {
-                return false;
+                RETURN_FALSE_INTERFACE
             }
         }
     }
 
     // On ES buffer mapping is an extension. On Desktop
     // buffer mapping was part of original VBO extension
     // which we require.
     if (kGL_GrGLStandard == fStandard || fExtensions.has("GL_OES_mapbuffer")) {
         if (NULL == fFunctions.fMapBuffer ||
             NULL == fFunctions.fUnmapBuffer) {
-            return false;
+            RETURN_FALSE_INTERFACE
         }
     }
 
     // Dual source blending
     if (kGL_GrGLStandard == fStandard &&
         (glVer >= GR_GL_VER(3,3) || fExtensions.has("GL_ARB_blend_func_extended"))) {
         if (NULL == fFunctions.fBindFragDataLocationIndexed) {
-            return false;
+            RETURN_FALSE_INTERFACE
         }
     }
 
     // glGetStringi was added in version 3.0 of both desktop and ES.
     if (glVer >= GR_GL_VER(3, 0)) {
         if (NULL == fFunctions.fGetStringi) {
-            return false;
+            RETURN_FALSE_INTERFACE
         }
     }
 
     if (kGL_GrGLStandard == fStandard) {
         if (glVer >= GR_GL_VER(3, 0) || fExtensions.has("GL_ARB_vertex_array_object")) {
             if (NULL == fFunctions.fBindVertexArray ||
                 NULL == fFunctions.fDeleteVertexArrays ||
                 NULL == fFunctions.fGenVertexArrays) {
-                return false;
+                RETURN_FALSE_INTERFACE
             }
         }
     } else {
         if (glVer >= GR_GL_VER(3,0) || fExtensions.has("GL_OES_vertex_array_object")) {
             if (NULL == fFunctions.fBindVertexArray ||
                 NULL == fFunctions.fDeleteVertexArrays ||
                 NULL == fFunctions.fGenVertexArrays) {
-                return false;
+                RETURN_FALSE_INTERFACE
             }
         }
     }
 
 #if 0
     if (fExtensions.has("GL_EXT_debug_marker")) {
         if (NULL == fFunctions.fInsertEventMarker ||
             NULL == fFunctions.fPushGroupMarker ||
             NULL == fFunctions.fPopGroupMarker) {
-            return false;
+            RETURN_FALSE_INTERFACE
         }
     }
 #endif
     return true;
 }