build/common.gypi - Issue 2094273003: Disable --as-needed for libpthread to work around linker bug.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 2094273003: Disable --as-needed for libpthread to work around linker bug. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Disable for android Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index 8db899a3434dd78a241cd4667556aa4bcd9a95b2..f5d107d0dc14f4b865cdaa75c592f66ef5d1ef08 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -3754,6 +3754,14 @@

'variables': {

'release_optimize%': 's',

+ }, {

+ 'ldflags': [

+ # TODO(pcc): Fix linker bug which requires us to link pthread

+ # unconditionally here (crbug.com/623236).

+ '-Wl,--no-as-needed',

+ '-lpthread',

+ '-Wl,--as-needed',

+ ],

}],

['profiling==1', {

'cflags': [

« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | build/config/compiler/BUILD.gn » ('J')