Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: build/common.gypi

Issue 2094273003: Disable --as-needed for libpthread to work around linker bug. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Disable for android Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | build/config/compiler/BUILD.gn » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 3736 matching lines...) Expand 10 before | Expand all | Expand 10 after
3747 # issues with libc++ (crbug.com/456380). 3747 # issues with libc++ (crbug.com/456380).
3748 'ldflags': [ 3748 'ldflags': [
3749 # Warn in case of text relocations. 3749 # Warn in case of text relocations.
3750 '-Wl,--warn-shared-textrel', 3750 '-Wl,--warn-shared-textrel',
3751 ], 3751 ],
3752 }], 3752 }],
3753 ['OS=="android"', { 3753 ['OS=="android"', {
3754 'variables': { 3754 'variables': {
3755 'release_optimize%': 's', 3755 'release_optimize%': 's',
3756 }, 3756 },
3757 }, {
3758 'ldflags': [
3759 # TODO(pcc): Fix linker bug which requires us to link pthread
3760 # unconditionally here (crbug.com/623236).
3761 '-Wl,--no-as-needed',
3762 '-lpthread',
3763 '-Wl,--as-needed',
3764 ],
3757 }], 3765 }],
3758 ['profiling==1', { 3766 ['profiling==1', {
3759 'cflags': [ 3767 'cflags': [
3760 '-fno-omit-frame-pointer', 3768 '-fno-omit-frame-pointer',
3761 '-g', 3769 '-g',
3762 ], 3770 ],
3763 'conditions' : [ 3771 'conditions' : [
3764 ['profiling_full_stack_frames==1', { 3772 ['profiling_full_stack_frames==1', {
3765 'cflags': [ 3773 'cflags': [
3766 '-fno-inline', 3774 '-fno-inline',
(...skipping 2556 matching lines...) Expand 10 before | Expand all | Expand 10 after
6323 # settings in target dicts. SYMROOT is a special case, because many other 6331 # settings in target dicts. SYMROOT is a special case, because many other
6324 # Xcode variables depend on it, including variables such as 6332 # Xcode variables depend on it, including variables such as
6325 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6333 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6326 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6334 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6327 # files to appear (when present) in the UI as actual files and not red 6335 # files to appear (when present) in the UI as actual files and not red
6328 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6336 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6329 # and therefore SYMROOT, needs to be set at the project level. 6337 # and therefore SYMROOT, needs to be set at the project level.
6330 'SYMROOT': '<(DEPTH)/xcodebuild', 6338 'SYMROOT': '<(DEPTH)/xcodebuild',
6331 }, 6339 },
6332 } 6340 }
OLDNEW
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | build/config/compiler/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698