Issue 2094273002: Fix evaluation of !=

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2094273002: Fix evaluation of != (Closed)

Created:
4 years, 5 months ago by Johnni Winther

Modified:
4 years, 5 months ago

Reviewers:
Harry Terkelsen

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix evaluation of != ConstantExpression.evaluate now computes != as the negation of the result of == R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/f010d5e01c5095eb90eb6a60a57ec964ab6b1309

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -3 lines)			Patch
M	pkg/compiler/lib/src/constants/expressions.dart	View	1	1 chunk	+12 lines, -3 lines	0 comments	Download
M	tests/compiler/dart2js/constant_expression_evaluate_test.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/compiler/dart2js/constant_expression_test.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Johnni Winther

4 years, 5 months ago (2016-06-28 07:41:55 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
f010d5e01c5095eb90eb6a60a57ec964ab6b1309 (presubmit successful).