Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: tests/compiler/dart2js/constant_expression_evaluate_test.dart

Issue 2094273002: Fix evaluation of != (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: dartfmt Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dart2js.constants.expressions.evaluate_test; 5 library dart2js.constants.expressions.evaluate_test;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'package:async_helper/async_helper.dart'; 8 import 'package:async_helper/async_helper.dart';
9 import 'package:expect/expect.dart'; 9 import 'package:expect/expect.dart';
10 import 'package:compiler/src/constants/evaluation.dart'; 10 import 'package:compiler/src/constants/evaluation.dart';
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 const List<TestData> DATA = const [ 48 const List<TestData> DATA = const [
49 const TestData('', const [ 49 const TestData('', const [
50 const ConstantData('null', const { const {} : 'NullConstant' }), 50 const ConstantData('null', const { const {} : 'NullConstant' }),
51 const ConstantData('false', const { const {} : 'BoolConstant(false)' }), 51 const ConstantData('false', const { const {} : 'BoolConstant(false)' }),
52 const ConstantData('true', const { const {} : 'BoolConstant(true)' }), 52 const ConstantData('true', const { const {} : 'BoolConstant(true)' }),
53 const ConstantData('0', const { const {} : 'IntConstant(0)' }), 53 const ConstantData('0', const { const {} : 'IntConstant(0)' }),
54 const ConstantData('0.0', const { const {} : 'DoubleConstant(0.0)' }), 54 const ConstantData('0.0', const { const {} : 'DoubleConstant(0.0)' }),
55 const ConstantData('"foo"', const { const {} : 'StringConstant("foo")' }), 55 const ConstantData('"foo"', const { const {} : 'StringConstant("foo")' }),
56 const ConstantData('1 + 2', const { const {} : 'IntConstant(3)' }), 56 const ConstantData('1 + 2', const { const {} : 'IntConstant(3)' }),
57 const ConstantData('-(1)', const { const {} : 'IntConstant(-1)' }), 57 const ConstantData('-(1)', const { const {} : 'IntConstant(-1)' }),
58 const ConstantData('1 == 2', const { const {} : 'BoolConstant(false)' }),
59 const ConstantData('1 != 2', const { const {} : 'BoolConstant(true)' }),
58 const ConstantData('"foo".length', const { const {} : 'IntConstant(3)' }), 60 const ConstantData('"foo".length', const { const {} : 'IntConstant(3)' }),
59 const ConstantData('identical(0, 1)', 61 const ConstantData('identical(0, 1)',
60 const { const {} : 'BoolConstant(false)' }), 62 const { const {} : 'BoolConstant(false)' }),
61 const ConstantData('"a" "b"', const { const {} : 'StringConstant("ab")' }), 63 const ConstantData('"a" "b"', const { const {} : 'StringConstant("ab")' }),
62 const ConstantData('identical', 64 const ConstantData('identical',
63 const { const {} : 'FunctionConstant(identical)' }), 65 const { const {} : 'FunctionConstant(identical)' }),
64 const ConstantData('true ? 0 : 1', const { const {} : 'IntConstant(0)' }), 66 const ConstantData('true ? 0 : 1', const { const {} : 'IntConstant(0)' }),
65 const ConstantData('proxy', 67 const ConstantData('proxy',
66 const { const {} : 'ConstructedConstant(_Proxy())' }), 68 const { const {} : 'ConstructedConstant(_Proxy())' }),
67 const ConstantData('Object', const { const {} : 'TypeConstant(Object)' }), 69 const ConstantData('Object', const { const {} : 'TypeConstant(Object)' }),
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
227 Environment environment = new MemoryEnvironment(compiler, env); 229 Environment environment = new MemoryEnvironment(compiler, env);
228 ConstantValue value = 230 ConstantValue value =
229 constant.evaluate(environment, DART_CONSTANT_SYSTEM); 231 constant.evaluate(environment, DART_CONSTANT_SYSTEM);
230 String valueText = value.toStructuredText(); 232 String valueText = value.toStructuredText();
231 Expect.equals(expectedText, valueText, 233 Expect.equals(expectedText, valueText,
232 "Unexpected value '${valueText}' for contant " 234 "Unexpected value '${valueText}' for contant "
233 "`${constant.toDartText()}`, expected '${expectedText}'."); 235 "`${constant.toDartText()}`, expected '${expectedText}'.");
234 }); 236 });
235 }); 237 });
236 } 238 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/constants/expressions.dart ('k') | tests/compiler/dart2js/constant_expression_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698