Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2094263002: Move the suborigin experiment to test-only mode. (Closed)

Created:
4 years, 5 months ago by Mike West
Modified:
4 years, 5 months ago
Reviewers:
jww
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Move the suborigin experiment to test-only mode. We're seeing crashes in the wild for folks with the experimental features flag turned on, as our suborigins implementation breaks origins that natively use an underscore in their DNS name (renderer crash with bad_message_reason 114 (RFH_INVALID_ORIGIN_ON_COMMIT)). This patch moves suborigins behind the test flag, so that it isn't enabled for users who have opted into experimental web platform features. We expect to re-enable it for those users once we've reworked serialization in https://github.com/w3c/webappsec-suborigins/issues/38 BUG=617588 TBR=jww@chromium.org Review-Url: https://codereview.chromium.org/2094873004 Cr-Commit-Position: refs/heads/master@{#401840} (cherry picked from commit 66ab9f9074c3d1082a7ab1062914fece3810c104) Committed: https://chromium.googlesource.com/chromium/src/+/307cf74bd38a7bb5482414061ada0da713f72a2f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Mike West
4 years, 5 months ago (2016-06-27 11:27:48 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
307cf74bd38a7bb5482414061ada0da713f72a2f.

Powered by Google App Engine
This is Rietveld 408576698