Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2094873004: Move the suborigin experiment to test-only mode. (Closed)

Created:
4 years, 6 months ago by Mike West
Modified:
4 years, 6 months ago
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move the suborigin experiment to test-only mode. We're seeing crashes in the wild for folks with the experimental features flag turned on, as our suborigins implementation breaks origins that natively use an underscore in their DNS name (renderer crash with bad_message_reason 114 (RFH_INVALID_ORIGIN_ON_COMMIT)). This patch moves suborigins behind the test flag, so that it isn't enabled for users who have opted into experimental web platform features. We expect to re-enable it for those users once we've reworked serialization in https://github.com/w3c/webappsec-suborigins/issues/38 BUG=617588 TBR=jww@chromium.org Committed: https://crrev.com/66ab9f9074c3d1082a7ab1062914fece3810c104 Cr-Commit-Position: refs/heads/master@{#401840}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Mike West
TBRing Joel for when he gets back from parental leave. Jochen, would you mind evaluating ...
4 years, 6 months ago (2016-06-24 08:04:53 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 6 months ago (2016-06-24 08:06:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2094873004/1
4 years, 6 months ago (2016-06-24 08:22:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 09:21:50 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 09:23:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/66ab9f9074c3d1082a7ab1062914fece3810c104
Cr-Commit-Position: refs/heads/master@{#401840}

Powered by Google App Engine
This is Rietveld 408576698