Source/modules/webaudio/OscillatorNode.cpp - Issue 209423006: WebAudio: Remove legacy support for numerical values for Oscillator types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webaudio/OscillatorNode.cpp

Issue 209423006: WebAudio: Remove legacy support for numerical values for Oscillator types. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/webaudio/OscillatorNode.cpp

diff --git a/Source/modules/webaudio/OscillatorNode.cpp b/Source/modules/webaudio/OscillatorNode.cpp

index a2d95dcb4a3508320a64deda6a12e2f669a2c7b4..24957597087a2c8234b1abc0b04e1883ee717df6 100644

--- a/Source/modules/webaudio/OscillatorNode.cpp

+++ b/Source/modules/webaudio/OscillatorNode.cpp

@@ -107,8 +107,6 @@ void OscillatorNode::setType(const String& type)

setType(SAWTOOTH);

else if (type == "triangle")

setType(TRIANGLE);

- else

- ASSERT_NOT_REACHED();

}

bool OscillatorNode::setType(unsigned type)

« no previous file with comments | « Source/modules/webaudio/OscillatorNode.h ('k') | Source/modules/webaudio/OscillatorNode.idl » ('j') | no next file with comments »