Add NaClChromeMainInitForNonSfi

Add NaClChromeMainInitForNonSfi

This initializer does less initialization than the one for
SFI NaCl. Particularly, NaClTlsInit will not be called so
that we can disallow modify_ldt in non-SFI mode by seccomp.

TEST=ninja -C out/Release nacl_helper
BUG=https://code.google.com/p/nativeclient/issues/detail?id=3734

[hamaji, 2014-03-28 07:22:51]

Oops, I forgot to ask the review of this change. This is a preparation of Bare
Metal seccomp. With this change, we can prohibit modify_ldt.

I'll also send a few preparation CLs for review.

[Mark Seaborn, 2014-03-28 14:09:45]

https://codereview.chromium.org/209423004/diff/1/src/trusted/service_runtime/...
File src/trusted/service_runtime/nacl_all_modules.c (right):

https://codereview.chromium.org/209423004/diff/1/src/trusted/service_runtime/...
src/trusted/service_runtime/nacl_all_modules.c:30: void
NaClAllModulesInitForNonSfi(void) {
Just call whatever Init functions you need directly on the Chrome side.  You can
change include_rules accordingly -- it's OK to whitelist things like SRPC since
src/trusted/plugin already uses that.  (SRPC will go away in the long term so
we're not trying to clean up the embedding interface NaCl provides for it.)

This list of Init functions doesn't belong in the NaCl repo because the code
using the facilities you're initialising isn't in the NaCl repo.

https://codereview.chromium.org/209423004/diff/1/src/trusted/service_runtime/...
src/trusted/service_runtime/nacl_all_modules.c:32: NaClGlobalModuleInit();  /*
various global variables */
I doubt you need this one.

[hamaji, 2014-03-30 03:34:06]

Thanks for the comment, Mark! I've closed this. I'll make another change to
nacl_listener.cc

[hamaji, 2014-04-01 07:10:38]

https://codereview.chromium.org/209423004/diff/1/src/trusted/service_runtime/...
File src/trusted/service_runtime/nacl_all_modules.c (right):

https://codereview.chromium.org/209423004/diff/1/src/trusted/service_runtime/...
src/trusted/service_runtime/nacl_all_modules.c:30: void
NaClAllModulesInitForNonSfi(void) {
On 2014/03/28 14:09:45, Mark Seaborn wrote:
> Just call whatever Init functions you need directly on the Chrome side.  You
can
> change include_rules accordingly -- it's OK to whitelist things like SRPC
since
> src/trusted/plugin already uses that.  (SRPC will go away in the long term so
> we're not trying to clean up the embedding interface NaCl provides for it.)
> 
> This list of Init functions doesn't belong in the NaCl repo because the code
> using the facilities you're initialising isn't in the NaCl repo.

I remembered a reason we need to call NaClChromeMainInit in Chrome side.
NaClChromeMainArgsCreate has CHECK(g_initialized) and as this is a file static
variable, we need to modify NaCl repository to set g_initialized and get rid of
NaClTlsInit.

Alternative solutions:

- Remove CHECK(g_initialized) from NaClChromeMainArgsCreate.
- Copy NaClChromeMainArgsCreate to chrome side for non-SFI.

I assume the last option is OK? I'll make a CL to see if you like this.

https://codereview.chromium.org/209423004/diff/1/src/trusted/service_runtime/...
src/trusted/service_runtime/nacl_all_modules.c:32: NaClGlobalModuleInit();  /*
various global variables */
On 2014/03/28 14:09:45, Mark Seaborn wrote:
> I doubt you need this one.

Removed.

[hamaji, 2014-04-01 07:59:31]

https://codereview.chromium.org/209423004/diff/1/src/trusted/service_runtime/...
File src/trusted/service_runtime/nacl_all_modules.c (right):

https://codereview.chromium.org/209423004/diff/1/src/trusted/service_runtime/...
src/trusted/service_runtime/nacl_all_modules.c:30: void
NaClAllModulesInitForNonSfi(void) {
On 2014/04/01 07:10:38, hamaji wrote:
> On 2014/03/28 14:09:45, Mark Seaborn wrote:
> > Just call whatever Init functions you need directly on the Chrome side.  You
> can
> > change include_rules accordingly -- it's OK to whitelist things like SRPC
> since
> > src/trusted/plugin already uses that.  (SRPC will go away in the long term
so
> > we're not trying to clean up the embedding interface NaCl provides for it.)
> > 
> > This list of Init functions doesn't belong in the NaCl repo because the code
> > using the facilities you're initialising isn't in the NaCl repo.
> 
> I remembered a reason we need to call NaClChromeMainInit in Chrome side.
> NaClChromeMainArgsCreate has CHECK(g_initialized) and as this is a file static
> variable, we need to modify NaCl repository to set g_initialized and get rid
of
> NaClTlsInit.
> 
> Alternative solutions:
> 
> - Remove CHECK(g_initialized) from NaClChromeMainArgsCreate.
> - Copy NaClChromeMainArgsCreate to chrome side for non-SFI.
> 
> I assume the last option is OK? I'll make a CL to see if you like this.
> 
> 

I guess we don't need to call NaClChromeMainArgsCreate at all... Let me see.

https://codereview.chromium.org/209423004/diff/1/src/trusted/service_runtime/...
src/trusted/service_runtime/nacl_all_modules.c:32: NaClGlobalModuleInit();  /*
various global variables */
On 2014/04/01 07:10:38, hamaji wrote:
> On 2014/03/28 14:09:45, Mark Seaborn wrote:
> > I doubt you need this one.
> 
> Removed.

This comment was just a mistake...