Add NaClChromeMainInitForNonSfi

src/trusted/service_runtime/nacl_all_modules.c

 /*
  * Copyright (c) 2012 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /*
  * Gather ye all module initializations and finalizations here.
  */
 #include "native_client/src/shared/srpc/nacl_srpc.h"
 #include "native_client/src/trusted/debug_stub/debug_stub.h"
 #include "native_client/src/trusted/desc/nrd_all_modules.h"
 #include "native_client/src/trusted/fault_injection/fault_injection.h"
 #include "native_client/src/trusted/service_runtime/nacl_globals.h"
 #include "native_client/src/trusted/service_runtime/nacl_syscall_handlers.h"
 #include "native_client/src/trusted/service_runtime/nacl_thread_nice.h"
 #include "native_client/src/trusted/service_runtime/nacl_tls.h"
 #include "native_client/src/trusted/service_runtime/nacl_stack_safety.h"
 
-void  NaClAllModulesInit(void) {
+void NaClAllModulesInit(void) {
   NaClNrdAllModulesInit();
   NaClFaultInjectionModuleInit();
   NaClGlobalModuleInit();  /* various global variables */
   NaClSrpcModuleInit();
   NaClTlsInit();
   NaClSyscallTableInit();
   NaClThreadNiceInit();
 }
 
+void NaClAllModulesInitForNonSfi(void) {

[Mark Seaborn, 2014/03/28 14:09:45]

Just call whatever Init functions you need directly on the Chrome side.  You can
change include_rules accordingly -- it's OK to whitelist things like SRPC since
src/trusted/plugin already uses that.  (SRPC will go away in the long term so
we're not trying to clean up the embedding interface NaCl provides for it.)

This list of Init functions doesn't belong in the NaCl repo because the code
using the facilities you're initialising isn't in the NaCl repo.

[hamaji, 2014/04/01 07:10:38]

I remembered a reason we need to call NaClChromeMainInit in Chrome side.
NaClChromeMainArgsCreate has CHECK(g_initialized) and as this is a file static
variable, we need to modify NaCl repository to set g_initialized and get rid of
NaClTlsInit.

Alternative solutions:

- Remove CHECK(g_initialized) from NaClChromeMainArgsCreate.
- Copy NaClChromeMainArgsCreate to chrome side for non-SFI.

I assume the last option is OK? I'll make a CL to see if you like this.

[hamaji, 2014/04/01 07:59:32]

I guess we don't need to call NaClChromeMainArgsCreate at all... Let me see.

+  NaClNrdAllModulesInit();
+  NaClGlobalModuleInit();  /* various global variables */

[Mark Seaborn, 2014/03/28 14:09:45]

I doubt you need this one.

[hamaji, 2014/04/01 07:10:38]

Removed.

[hamaji, 2014/04/01 07:59:32]

This comment was just a mistake...

+  NaClSrpcModuleInit();
+}
 
 void NaClAllModulesFini(void) {
   NaClTlsFini();
   NaClSrpcModuleFini();
   NaClGlobalModuleFini();
   NaClNrdAllModulesFini();
 }
+
+void NaClAllModulesFiniForNonSfi(void) {
+  NaClSrpcModuleFini();
+  NaClGlobalModuleFini();
+  NaClNrdAllModulesFini();
+}