Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 2094223002: X87: [builtins] Use BUILTIN frame in DatePrototype_GetField. (Closed)

Created:
4 years, 5 months ago by zhengxing.li
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [builtins] Use BUILTIN frame in DatePrototype_GetField. port 198e09de5a72eb734918bdf3943f37202fdc644d (r37053) original commit message: Construct a BUILTIN frame before throwing an exception from runtime. BUG= Committed: https://crrev.com/b0c570515950fde606c710dc0d97f520f04d958e Cr-Commit-Position: refs/heads/master@{#37275}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M src/x87/builtins-x87.cc View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 5 months ago (2016-06-27 07:35:51 UTC) #2
Weiliang
lgtm
4 years, 5 months ago (2016-06-27 07:40:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2094223002/1
4 years, 5 months ago (2016-06-27 07:41:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 08:03:39 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 08:04:04 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b0c570515950fde606c710dc0d97f520f04d958e
Cr-Commit-Position: refs/heads/master@{#37275}

Powered by Google App Engine
This is Rietveld 408576698